You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2026/06/10 22:13:03 UTC
[PR] Feat note accordion [airflow]
bbovenzi opened a new pull request, #68362:
URL: https://github.com/apache/airflow/pull/68362
Closes https://github.com/apache/airflow/issues/52516
Upgrade our notes ux:
- go back to using an accordion with a one line preview in the header
- Add the note icon to dag run and task instance list pages to edit the note in a modal
<img width="1312" height="635" alt="Screenshot 2026-06-10 at 2 59 36 PM" src="https://github.com/user-attachments/assets/7f89fc95-27e5-4f3e-b013-757566a9e331" />
<img width="1320" height="693" alt="Screenshot 2026-06-10 at 2 59 43 PM" src="https://github.com/user-attachments/assets/36f0b01a-d4a3-4ea8-9684-d05c96596ba7" />
<img width="1313" height="605" alt="Screenshot 2026-06-10 at 2 59 48 PM" src="https://github.com/user-attachments/assets/d625ab30-a3b0-4165-bf4d-171cb94d9cf0" />
<img width="721" height="406" alt="Screenshot 2026-06-10 at 3 00 07 PM" src="https://github.com/user-attachments/assets/a345b548-22c9-4409-944d-b073418aa88d" />
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Clause Sonnet 4.6
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note accordion [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #68362:
URL: https://github.com/apache/airflow/pull/68362#issuecomment-4685252405
> > @eladkal we removed that in 3.0 in order to show dag versioning in the grid view
>
> I am aware we removed it but I don't understand where is the conflict? I don't see version indication on the dagrun grid
I _think_ I remember the reasoning to remove it from Gris was (1) performance in the Grid query to fetch if note is existing (adds a join to note table) as (2) well as there was the feeling that the additional highlight "clutters" the view.
I tend to say was beneficial to have the markers but frakly speaking most users did not understand it. I remember it very positive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note accordion [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #68362:
URL: https://github.com/apache/airflow/pull/68362#issuecomment-4675361437
cc: @eladkal @jscheffl
I am not sure I like the accordion but this one is at least more manageable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note accordion [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #68362:
URL: https://github.com/apache/airflow/pull/68362#issuecomment-4710424357
I'll fix this all tonight
@eladkal please open a separate GitHub issue. Changes to the grid is not in scope for this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note accordion [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #68362:
URL: https://github.com/apache/airflow/pull/68362#issuecomment-4685557274
@bbovenzi Thanks for the re-placement of the Note! This is a bit feeling like the proposal I had a longer time ago in https://github.com/apache/airflow/pull/51764 with a bit improved folding. This improves for the proposed AIP-102 already 10% of what we need/want :-) - FYI @AutomationDev85
I think is better than before 3.3.0, but two nit to be considering from my view:
1) When navigating from a task to another (or to a run) the initial display of the note is always "folded to a single line" - this is good to save space but for a user it is not obvious that there it more than one line until he / she clicks. Is there any visual possible to inform that there is more than one line? Else in-experienced users might miss all from the second line and medium experienced users maybe only catch the first intro.
2) (Also a problem in 3.0, 3.1 and 3.2): If a link is rendered in Markdown then is is well displayed, but clicking on it gets user to edit mode. You basically need to copy&paste a markdown link and open manually. Is there an option to have the z-index with priority that a click on a link is respecting the link and edit mode is only made when you click not on a link?
3) I see there is no length validation in the new note. Notes (unfortunately) are limited to 1000 chars (maybe I need to contribute a feature allowing it to be more like a CLOB... 1000 chars as markdown might be a bit limiting...) - If you type more you just get an error that saving failed.
https://github.com/user-attachments/assets/54cc5146-ae6e-44f2-93c0-5e6dba52e4ed
P.S.: @dheerajturaga I rememebr you also would LOVE to have this in 3.3.0? :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note accordion [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #68362:
URL: https://github.com/apache/airflow/pull/68362#issuecomment-4678042987
I expected to see an indication on the grid. Am I missing something?
<img width="584" height="372" alt="Screenshot 2026-06-11 at 10 04 43" src="https://github.com/user-attachments/assets/c4a80b1a-a0ed-4d17-a60e-664804f18ddc" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note accordion [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #68362:
URL: https://github.com/apache/airflow/pull/68362#issuecomment-4698020746
> I tend to say was beneficial to have the markers but frakly speaking most users did not understand it. I remember it very positive.
I don't understand this statement. You are describing a UX challange which we can resolve. But @bbovenzi mentioned a complexity challange around performance which is something else entirely.
May I also point that some users disable dag versioning and even when disabled we don't have the marker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note accordion [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #68362:
URL: https://github.com/apache/airflow/pull/68362#issuecomment-4682709075
> @eladkal we removed that in 3.0 in order to show dag versioning in the grid view
I am aware we removed it but I don't understand where is the conflict? I don't see version indication on the dagrun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note modal [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #68362:
URL: https://github.com/apache/airflow/pull/68362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note accordion [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #68362:
URL: https://github.com/apache/airflow/pull/68362#issuecomment-4699653585
> > I tend to say was beneficial to have the markers but frakly speaking most users did not understand it. I remember it very positive.
>
> I don't understand this statement. You are describing a UX challange which we can resolve. But @bbovenzi mentioned a complexity challange around performance which is something else entirely.
>
> May I also point that some users disable dag versioning and even when disabled we don't have the marker.
Yes, sorry. Bad English. Yes, I remember it was a performance thung and therefore (until now) it was not re-implemented. But am only 80% sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note accordion [airflow]
Posted by "dheerajturaga (via GitHub)" <gi...@apache.org>.
dheerajturaga commented on PR #68362:
URL: https://github.com/apache/airflow/pull/68362#issuecomment-4695480241
Awesome! We were missing this feature from 2.x and very much liked it
Glad it's back! 🥳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note modal [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #68362:
URL: https://github.com/apache/airflow/pull/68362#issuecomment-4715723178
Ok. Reverted back to a modal but with a one line preview in the task and run header. But the modal has write/preview functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note modal [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #68362:
URL: https://github.com/apache/airflow/pull/68362#issuecomment-4715806534
> @eladkal please open a separate GitHub issue. Changes to the grid is not in scope for this PR
Ho wow. I completely read the issue wrong!
I read it as missing the note indication in the grid not as missing the note itself from the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note accordion [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #68362:
URL: https://github.com/apache/airflow/pull/68362#issuecomment-4682349575
@pierrejeambrun Updated. I was playing with custom headers, but it messed the rest up
@eladkal we removed that in 3.0 in order to show dag versioning in the grid view
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat note accordion [airflow]
Posted by "dheerajturaga (via GitHub)" <gi...@apache.org>.
dheerajturaga commented on PR #68362:
URL: https://github.com/apache/airflow/pull/68362#issuecomment-4714452577
I had a chance to review the changes. Cool and much needed feature.
Few notes:
- Clicking on the note immediately puts me in edit mode and one may accidentally modify the contents of the note. (
- It is also not obvious at first glance that a note maybe present.
I was thinking it would be better if it were a large note be displayed in a popup menu with an additional option to edit? or better yet provide a github comment style interface with `write` and `preview` ? ( thinking out loud here, taking inspiration from the comment section on github)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org