[jira] [Commented] (NIFI-5672) Node Identifier comparison can result in duplicate nodes in cluster when upgrading to newest version

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643696#comment-16643696 ] 

ASF GitHub Bot commented on NIFI-5672:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/3054

    NIFI-5672: Do not compare Load Balancing address/port for logical equ…

    …ivalence of Node Identifiers. Added more details to logging of Node Identifiers
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-5672

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3054.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3054
    
----
commit 70515b43492bafe293f2be07be9ff308cbb71ebf
Author: Mark Payne <ma...@...>
Date:   2018-10-09T16:19:24Z

    NIFI-5672: Do not compare Load Balancing address/port for logical equivalence of Node Identifiers. Added more details to logging of Node Identifiers

----


> Node Identifier comparison can result in duplicate nodes in cluster when upgrading to newest version
> ----------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-5672
>                 URL: https://issues.apache.org/jira/browse/NIFI-5672
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Major
>             Fix For: 1.8.0
>
>
> Now that the Load Balancing capability has been merged to master, upgrading old clusters works okay as long as the Load Balancing port is properly specified. However, if the cluster is restarted without specifying the port, and the port is then changed, we get duplicate representations of the nodes in the cluster.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)