You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2023/12/18 03:14:43 UTC

Re: [PR] Adding gRPC samples to docs. [incubator-pekko]

laglangyue commented on code in PR #696:
URL: https://github.com/apache/incubator-pekko/pull/696#discussion_r1429439473


##########
docs/src/main/paradox/typed/guide/modules.md:
##########
@@ -272,6 +272,8 @@ Some of the challenges that HTTP tackles:
 
 This library provides an implementation of gRPC that integrates nicely with the @ref:[HTTP](#http) and @ref:[Streams](#streams) modules.  It is capable of generating both client and server-side artifacts from protobuf service definitions, which can then be exposed using Pekko HTTP, and handled using Streams.
 
+A sample using the gRPC module can be found at: @extref[gRPC on Kubernetes example project](samples:pekko-sample-grpc-kubernetes-scala)

Review Comment:
   It doesn't seem necessary to add it here to maintain a consistent style,and links to samples in example already.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org