You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/03/23 16:14:55 UTC
[GitHub] [ignite-3] sashapolo opened a new pull request #745: IGNITE-16729 Fix flaky test
sashapolo opened a new pull request #745:
URL: https://github.com/apache/ignite-3/pull/745
https://issues.apache.org/jira/browse/IGNITE-16729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov merged pull request #745: IGNITE-16729 Fix flaky test
Posted by GitBox <gi...@apache.org>.
ibessonov merged pull request #745:
URL: https://github.com/apache/ignite-3/pull/745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a change in pull request #745: IGNITE-16729 Fix flaky test
Posted by GitBox <gi...@apache.org>.
tkalkirill commented on a change in pull request #745:
URL: https://github.com/apache/ignite-3/pull/745#discussion_r833930290
##########
File path: modules/core/src/test/java/org/apache/ignite/internal/testframework/WorkDirectoryExtension.java
##########
@@ -176,7 +176,9 @@ private static Path createWorkDir(ExtensionContext context) throws IOException {
.map(Method::getName)
.orElse(STATIC_FOLDER_NAME);
- Path workDir = getTestClassDir(context).resolve(testMethodDir + '_' + System.currentTimeMillis());
+ // not using currentTimeMillis because some tests can have the same name (e.g. repeated tests) and execute in less than a
Review comment:
```suggestion
// Not using currentTimeMillis because some tests can have the same name (e.g. repeated tests) and execute in less than a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org