[jira] [Commented] (OFBIZ-12811) disabledDateTime shouldn't be set for UserLogin within the setPartyStatus method in PartyServices.java

["Jacques Le Roux (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-12811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718827#comment-17718827 ] 

Jacques Le Roux commented on OFBIZ-12811:
-----------------------------------------

Hi Tobias,

Are we sure we want to do that? It was perfectly explained by David in 2009: https://markmail.org/message/xmfvvvy2ybdcxfib
Setting 0, as says the comment in security.properties, do the same. So this property allows more and can be useful in production as David explained.
# -- disable the account for this many minutes (if 0, then indefinite) --
login.disable.minutes=5


> disabledDateTime shouldn't be set for UserLogin within the setPartyStatus method in PartyServices.java
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-12811
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12811
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: 18.12.07
>            Reporter: Tobias Hahn
>            Assignee: Tobias Hahn
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>
> Within the setPartyStatus method in PartyServices.java there is a bug regarding the disabledDateTime field (line 242). This field shouldn't be set because then the login service may re-enable the UserLogin automatically at next login attempt. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)