You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/04/15 15:54:52 UTC
[jira] Created: (LUCENE-2396) remove version from
contrib/analyzers.
remove version from contrib/analyzers.
--------------------------------------
Key: LUCENE-2396
URL: https://issues.apache.org/jira/browse/LUCENE-2396
Project: Lucene - Java
Issue Type: Task
Components: contrib/analyzers
Affects Versions: 3.1
Reporter: Robert Muir
Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857412#action_12857412 ]
Robert Muir commented on LUCENE-2396:
-------------------------------------
bq. Until we have no more analyzers in core exspect Whitespace.
Actually i think whitespace belongs in analyzers module too. I would suggest a TestAnalyzer in src/test, which might just be quick-and-dirty or whatever.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857321#action_12857321 ]
Robert Muir commented on LUCENE-2396:
-------------------------------------
Additionally, i would like to remove all "CHANGES from backwards compatibility policy" from contrib/CHANGES.
contrib has no backwards compatibility policy, so it makes no sense. these are just ordinary changes for Contrib.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from core and
contrib analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857556#action_12857556 ]
Robert Muir commented on LUCENE-2396:
-------------------------------------
bq. Hmmm. If we are moving stuff out of core and into contrib, don't we need to have a version that matches 3.0 for a first release?
No, fixing core sorta assumes that 3.1 is a major release.
but we can do the patch on the issue now, since because contrib has no backwards compat policy.
> remove version from core and contrib analyzers.
> -----------------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857388#action_12857388 ]
Shai Erera commented on LUCENE-2396:
------------------------------------
Robert I think this is great! Can we move more analyzers from core here? I think however that a backwards section in changes is important because it alerts users about those analyzers whose runtime behavior changed. Otherwise how would the poor uses know that? It doesn't mean you need to maintain back compat support but at least alert them when things change.
Even if we eventually decide to remove API bw completely, a section in CHANGES will still be required to help users upgrade easily.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "DM Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857487#action_12857487 ]
DM Smith commented on LUCENE-2396:
----------------------------------
bq. Well, I think asking for a well-defined backwards compatibility policy for 'all analyzers' is asking too much. Things are not so simple and sorted out like they are with English/porter stemming, etc.
Some ramblings:
I think things need to change/improve wrt analyzers, tokenizers and filters. The current Version mechanism is a road block. So is bw compat. I get that.
When I asked for a well-define compatibility policy, I was not suggesting that we go back to the old mechanism or keep the new Version mechanism. Just a clear statement on what the policy is. It might be on a per class basis.
One mechanism that would work is versioned Java package names or class names. The current release would get the good names. If a user wanted the old jar they'd have to get it from the current release (e.g. lucene-analyzers-3.5_3.0.jar) and then change their code to use the old stuff which now has either a new package name or a new class name. Example, trStemmer.java is going to be changed as the first breaking change since 3.0, so trStemmer3_0.java is created as a copy and then trStemmer.java is changed.
The compatibility policy would be that the jar is not a drop in replacement, but that the old classes still exist, albeit with a different name.
I have worked on some contributions w/ bw compat and it is a pain. I didn't like it. And that was both pre-version and post-version. I'd like to see version go away, but I'm not sure I'd like bw compat to go away. As it is I'm resigning myself that as I use each release of Lucene, I'm going to want more from it and that is likely to require index rebuilds. Right now I'm stuck with the 2.9 series and what happens until I upgrade to 3.x or 4.x doesn't really impact me. It will impact me then. I'll figure out how to deal with it and suck it up.
Some other things I'd like to see:
* I'd like to see fully controllable Unicode support. The only way I see this is if we use ICU. It will take the java version problem out of the picture. A user would have control of the version of Unicode by their control of the version of ICU.
* An analyzer construction factory, that would take a spec (of fields, tokenizers, stop words, stemmers, ....) and spit out an per field analyzer. This would allow for the deprecation of the analyzers.
These and others would be more readily tackled if the bw compat policy did not get in the way.
bq. I'll go with the flow, we can stay with what we have now, and the language support will also likely remain weak like it is now.
You know I don't want that ;)
I was suggesting that this issue should wait to see what the outcome of the general Version discussion is. Even if it is negative, perhaps this can go forward.
bq.Currently I feel its an immense up-front effort to contribute any analysis support, it has to be near-perfect less it will cause future problems, because its not easy to iterate with the current situation without creating a mess.
With new stuff, even in core, if it is marked as experimental, it is outside the bw compat policy. That gives the opportunity to iterate. Dev branches are another good way.
But please, keep up the good work!
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "DM Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857427#action_12857427 ]
DM Smith commented on LUCENE-2396:
----------------------------------
Robert,
I think this is a red-herring. There has been an implicit bw compat policy, with all the effort to maintain bw compat in the analyzers. With the re-shuffling of contrib this has been made a bit murky and does need to be re-addressed.
How is this any different than the discussion to eliminate Version altogether? I think that should be resolved first and this follow the lead of that.
How can one have a useful index across releases without a stable token stream? From the thread it is clear that few understand the impact of an analyzer on the usefulness of an index.
If this succeeds there is little reason to maintain Version at all.
-- DM
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2396) remove version from core and contrib
analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2396:
--------------------------------
Summary: remove version from core and contrib analyzers. (was: remove version from contrib/analyzers.)
As Shai mentioned on the dev list:
Robert ... I'm sorry but changes to Analyzers don't *force* people to reindex. They can simply choose not to use the latest version.
So because of this, I will be updating the patch to remove all cruft from Lucene core as well.
> remove version from core and contrib analyzers.
> -----------------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857466#action_12857466 ]
Robert Muir commented on LUCENE-2396:
-------------------------------------
bq. I could live with that....maybe. What guarantee is there that lucene-analyzers-3.0.jar will work with lucene-core-3.7.jar? How does that work?
Well, they should work, unless lucene-core breaks backwards compatibility with analyzers!
{quote}
How can I use lucene-analyzers-3.0.jar on old indexes and lucene-analyzers-3.5.jar on newer ones within the same application?
What I'd like to see is that all analyzers and their parts are kept together in an analyzer jar (maybe more than one for the honking big analyzers as we have today) and that it be elevated to core. (I think contrib give the wrong impression.) And have a well-define compatibility policy.
{quote}
Well, I think asking for a well-defined backwards compatibility policy for 'all analyzers' is asking too much. Things are not so simple and sorted out like they are with English/porter stemming, etc.
I'll go with the flow, we can stay with what we have now, and the language support will also likely remain weak like it is now.
Currently I feel its an immense up-front effort to contribute any analysis support, it has to be near-perfect less it will cause future problems, because its not easy to iterate with the current situation without creating a mess.
Forget about applying little patches or improvements (assuming adequately relevance-tested / sane etc)... we've really only been able to fix bugs, add tests, and reorganize analyzers because touching them at all means you have to add backwards compat cruft.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2396:
--------------------------------
Attachment: LUCENE-2396.patch
attached is a patch, including CHANGES rewording.
All Lucene/Solr tests pass.
If no one objects, I plan to commit in a day or two.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857325#action_12857325 ]
Robert Muir commented on LUCENE-2396:
-------------------------------------
Also, i would like to remove all deprecated methods from contrib/analyzers as well.
this again shouldnt be a problem, as it has no back compat policy.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "DM Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857456#action_12857456 ]
DM Smith commented on LUCENE-2396:
----------------------------------
{quote}
So I think we should instead use real-versions for contrib/analyzers. You can be damn sure if you stick with lucene-analyzers-3.0.jar that your stemmer isn't going to change behavior... no matter how much backwards stuff we try to add, this is easiest and safest on everyone.
{quote}
I could live with that....maybe. What guarantee is there that lucene-analyzers-3.0.jar will work with lucene-core-3.7.jar? How does that work?
How can I use lucene-analyzers-3.0.jar on old indexes and lucene-analyzers-3.5.jar on newer ones within the same package?
What I'd like to see is that all analyzers and their parts are kept together in an analyzer jar (maybe more than one for the honking big analyzers as we have today) and that it be elevated to core. (I think contrib give the wrong impression.) And have a well-define compatibility policy.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857398#action_12857398 ]
Robert Muir commented on LUCENE-2396:
-------------------------------------
{quote}
Static? Weren't you against that!?
But if we remove back compat from analyzers why do we need Version? Or is this API bw that we remove?
{quote}
Whoah... don't get too excited :).
*Internally* some of these contrib analyzers subclass stuff thats in lucene core, which requires Version.
If this stuff was moved into say, contrib analyzers, then we wouldnt need this *Internal-only-use* Version arg.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857440#action_12857440 ]
Robert Muir commented on LUCENE-2396:
-------------------------------------
bq. There has been an implicit bw compat policy,
Part of the point of this patch for me was two things:
# what would the code look like if we delete the back compat cruft?
# why do i constantly hear different ideas about what contrib/analyzer's back compat and what it should be? I want it defined!
At first I said, this is a stupid idea, but I am gonna delete all the backwards cruft from a few Analyzers and just give it a try... its amazing how much easier it is to see what is going on when you delete the 1.8MB of backwards crap... a lot of it i put a lot of effort myself into.
So I think we should instead use real-versions for contrib/analyzers. You can be damn sure if you stick with lucene-analyzers-3.0.jar that your stemmer isn't going to change behavior... no matter how much backwards stuff we try to add, this is easiest and safest on everyone.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857396#action_12857396 ]
Shai Erera commented on LUCENE-2396:
------------------------------------
Static? Weren't you against that!?
But if we remove back compat from analyzers why do we need Version? Or is this API bw that we remove?
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from core and
contrib analyzers.
Posted by "DM Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857543#action_12857543 ]
DM Smith commented on LUCENE-2396:
----------------------------------
Hmmm. If we are moving stuff out of core and into contrib, don't we need to have a version that matches 3.0 for a first release?
I can't put my finger on it but something seems like it will come back to bite.
> remove version from core and contrib analyzers.
> -----------------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir reassigned LUCENE-2396:
-----------------------------------
Assignee: Robert Muir
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857507#action_12857507 ]
Robert Muir commented on LUCENE-2396:
-------------------------------------
bq. I can go along with this.
Cool!
bq. I still think it might be good to let the dust settle on the general Version question before committing.
Sure... but we should still remember there's really no back compat for the stuff changed in this patch :)
I'm also glad you mentioned the unicode issue, i mean if you are doing non-English, some of the ideas in lucene's back compat with analyzers are basically downright silly at the end of the day.
Besides the fact that upgrading your JVM can cause java itself to treat text differently (which we currently cannot control), changes to the users operating system [potentially completely outside of the scope of your application!] can cause 'searches that worked before to not work anymore'.
For example, if your users upgrade and their new input method generates U+09CE instead of U+09A4 U+09CD U+200D for Khanda-ta, the search won't match, even though perhaps they typed the exact same key on their keyboard.
Unicode normalization does nothing in this case, and its your app's responsibility to be aware of stuff like this (Not Lucene's analyzers!) and deal with them.
At the end of the day, I think a lot of what lucene considers our own backwards compatibility responsibility necessarily belongs in the app instead.
{noformat}
Versions of the Unicode Standard prior to Version 4.1 recommended that khanda ta be represented
as the sequence <U+09A4 bengali letter ta, U+09CD bengali sign virama,
U+200D zero width joiner> in all circumstances. U+09CE bengali letter khanda ta
should instead be used explicitly in newly generated text, but users are cautioned that
instances of the older representation may exist.
{noformat}
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "DM Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857498#action_12857498 ]
DM Smith commented on LUCENE-2396:
----------------------------------
{quote}
bq. One mechanism that would work is versioned Java package names or class names. The current release would get the good names. If a user wanted the old jar they'd have to get it from the current release (e.g. lucene-analyzers-3.5_3.0.jar) and then change their code to use the old stuff which now has either a new package name or a new class name. Example, trStemmer.java is going to be changed as the first breaking change since 3.0, so trStemmer3_0.java is created as a copy and then trStemmer.java is changed.
Right, but I dont think Lucene should manage this. I think if we assume "normally versioned releases", a user with a really complex case that needs multiple versions of lucene working in the same JVM , like you, could use some other tool (eclipse refactor or maybe google's jarjar) to do rename things?
{quote}
I can go along with this.
I still think it might be good to let the dust settle on the general Version question before committing.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "DM Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857456#action_12857456 ]
DM Smith edited comment on LUCENE-2396 at 4/15/10 2:16 PM:
-----------------------------------------------------------
{quote}
So I think we should instead use real-versions for contrib/analyzers. You can be damn sure if you stick with lucene-analyzers-3.0.jar that your stemmer isn't going to change behavior... no matter how much backwards stuff we try to add, this is easiest and safest on everyone.
{quote}
I could live with that....maybe. What guarantee is there that lucene-analyzers-3.0.jar will work with lucene-core-3.7.jar? How does that work?
How can I use lucene-analyzers-3.0.jar on old indexes and lucene-analyzers-3.5.jar on newer ones within the same application?
What I'd like to see is that all analyzers and their parts are kept together in an analyzer jar (maybe more than one for the honking big analyzers as we have today) and that it be elevated to core. (I think contrib give the wrong impression.) And have a well-define compatibility policy.
was (Author: dmsmith):
{quote}
So I think we should instead use real-versions for contrib/analyzers. You can be damn sure if you stick with lucene-analyzers-3.0.jar that your stemmer isn't going to change behavior... no matter how much backwards stuff we try to add, this is easiest and safest on everyone.
{quote}
I could live with that....maybe. What guarantee is there that lucene-analyzers-3.0.jar will work with lucene-core-3.7.jar? How does that work?
How can I use lucene-analyzers-3.0.jar on old indexes and lucene-analyzers-3.5.jar on newer ones within the same package?
What I'd like to see is that all analyzers and their parts are kept together in an analyzer jar (maybe more than one for the honking big analyzers as we have today) and that it be elevated to core. (I think contrib give the wrong impression.) And have a well-define compatibility policy.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from core and
contrib analyzers.
Posted by "DM Smith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857595#action_12857595 ]
DM Smith commented on LUCENE-2396:
----------------------------------
Humor me. I think I'm not seeing the forest for the trees.
Suppose an app is using Lucene at 3.0 and that this patch has been applied to trunk and only affects contrib/analyzers (I assume as I did not look at the patch;)
Then 3.1 is released. How does the user upgrade to 3.1? Let me see if I get this right. Since Version has been ripped out their code won't compile? Easy enough, change to a comparable constructor.
bq. No, fixing core sorta assumes that 3.1 is a major release.
That's what I was thinking. So it shouldn't be 3.1 but rather 4.0? (And even w/o refactoring isn't flex big enough to warrant 4.0?)
But still isn't some sort of bridge release needed to get the user to the new paradigm?
Assume they are only using lucene-core-3.0.jar and not lucene-analyzers-3.0.jar. In 3.1 they need both jars. But you can't mix 3.0 and 3.1 combinations of the two jars at all. After 3.1 it is possible to mix and match.
> remove version from core and contrib analyzers.
> -----------------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857386#action_12857386 ]
Robert Muir commented on LUCENE-2396:
-------------------------------------
bq. Are you sure you want to use LUCENE_CURRENT in some ctors?
The lucene core subclasses used by some analyzers require this, so another alternative is to create a static CONTRIB_ANALYZERS_VERSION = 3.1 for this purpose, and bump it every release. that's fine too.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857384#action_12857384 ]
Uwe Schindler commented on LUCENE-2396:
---------------------------------------
Are you sure you want to use LUCENE_CURRENT in some ctors?
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857402#action_12857402 ]
Uwe Schindler commented on LUCENE-2396:
---------------------------------------
bq. Static? Weren't you against that!?
He meant a static final! It is just to make the analyzers that depend on core stuff fix to a specific version. Until we have no more analyzers in core exspect Whitespace.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857395#action_12857395 ]
Robert Muir commented on LUCENE-2396:
-------------------------------------
{quote}
Robert I think this is great! Can we move more analyzers from core here? I think however that a backwards section in changes is important because it alerts users about those analyzers whose runtime behavior changed. Otherwise how would the poor uses know that? It doesn't mean you need to maintain back compat support but at least alert them when things change.
{quote}
I think this belongs in Changes in Runtime Behavior. Its a question of wording..., which is why i renamed it as such in the patch.
If folks want to move the analyzers in core into here, that would be great too, even better the Solr analyzers. we can call it a module if we want, or whatever.
But for now, I'm working with what I got.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857490#action_12857490 ]
Robert Muir commented on LUCENE-2396:
-------------------------------------
{quote}
One mechanism that would work is versioned Java package names or class names. The current release would get the good names. If a user wanted the old jar they'd have to get it from the current release (e.g. lucene-analyzers-3.5_3.0.jar) and then change their code to use the old stuff which now has either a new package name or a new class name. Example, trStemmer.java is going to be changed as the first breaking change since 3.0, so trStemmer3_0.java is created as a copy and then trStemmer.java is changed.
{quote}
Right, but I dont think Lucene should manage this. I think if we assume "normally versioned releases", a user with a really complex case that needs multiple versions of lucene working in the same JVM , like you, could use some other tool (eclipse refactor or maybe google's jarjar) to do rename things?
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2396) remove version from
contrib/analyzers.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857471#action_12857471 ]
Robert Muir commented on LUCENE-2396:
-------------------------------------
bq. How can I use lucene-analyzers-3.0.jar on old indexes and lucene-analyzers-3.5.jar on newer ones within the same application?
sorry DM, i meant to respond to this too!
I think this is an advanced use case, that doesn't justify complex backwards compatibility layers.
> remove version from contrib/analyzers.
> --------------------------------------
>
> Key: LUCENE-2396
> URL: https://issues.apache.org/jira/browse/LUCENE-2396
> Project: Lucene - Java
> Issue Type: Task
> Components: contrib/analyzers
> Affects Versions: 3.1
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2396.patch
>
>
> Contrib/analyzers has no backwards-compatibility policy, so let's remove Version so the API is consumable.
> if you think we shouldn't do this, then instead explicitly state and vote on what the backwards compatibility policy for contrib/analyzers should be instead, or move it all to core.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org