You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Zhijiang (Jira)" <ji...@apache.org> on 2020/04/27 10:53:00 UTC

[jira] [Updated] (FLINK-17413) Refactor the usages of ThreadSafeUnaligner#storeNewBuffers

     [ https://issues.apache.org/jira/browse/FLINK-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhijiang updated FLINK-17413:
-----------------------------
    Summary: Refactor the usages of ThreadSafeUnaligner#storeNewBuffers  (was: Remove redundant states from ThreadSafeUnaligner)

> Refactor the usages of ThreadSafeUnaligner#storeNewBuffers
> ----------------------------------------------------------
>
>                 Key: FLINK-17413
>                 URL: https://issues.apache.org/jira/browse/FLINK-17413
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Checkpointing
>            Reporter: Zhijiang
>            Assignee: Zhijiang
>            Priority: Major
>
> In RemoteInputChannel, we already have the states  of `lastRequestedCheckpointId` and `receivedCheckpointId` to control whether the received buffer should be notified to unaligner component. 
> In current ThreadSafeUnaligner, the variable `storeNewBuffers` is also used for similar purpose to deciding whether the notified buffer should be written into persister. In other words, as long as the `RemoteInputChannel` decides to notify this received buffer, it should be always needed to spill. So we can remove the variable `storeNewBuffers` from ThreadSafeUnaligner completely.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)