You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "Maxwell-Guo (via GitHub)" <gi...@apache.org> on 2023/12/04 04:36:45 UTC
Re: [PR] Move format-specific sstable options into the format configuration [cassandra]
Maxwell-Guo commented on code in PR #2879:
URL: https://github.com/apache/cassandra/pull/2879#discussion_r1413354428
##########
src/java/org/apache/cassandra/io/sstable/indexsummary/IndexSummaryManager.java:
##########
@@ -99,24 +106,26 @@ private IndexSummaryManager(Supplier<List<T>> indexSummariesProvider)
this.indexSummariesProvider = indexSummariesProvider;
executor = executorFactory().scheduled(false, "IndexSummaryManager", Thread.MIN_PRIORITY);
-
- long indexSummarySizeInMB = DatabaseDescriptor.getIndexSummaryCapacityInMiB();
- int interval = DatabaseDescriptor.getIndexSummaryResizeIntervalInMinutes();
+ // TODO make format get from default format
+ format = DatabaseDescriptor.getSelectedSSTableFormat();
Review Comment:
` if there are multiple, we should probably check that the options they provide match`
I think we can only get all the sstable formats provided from DatabaseDescriptor.getSSTableFormats() to fetch all the formats , there may exists some format that support IndexSummaryConfiguration but, I am not clear with `match` mean? And for me, `IndexSummaryManager` seems can not be table level, So I used `DatabaseDescriptor.getSelectedSSTableFormat()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org