[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6400: Upgrade Cache Stats Traffic Portal view to use AG-Grid tables

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #6400:
URL: https://github.com/apache/trafficcontrol/pull/6400#discussion_r762022653



##########
File path: traffic_portal/app/src/modules/private/cacheStats/CacheStatsController.js
##########
@@ -17,60 +17,218 @@
  * under the License.
  */
 
-var CacheStatsController = function(cacheStats, $scope, $state, $interval, numberUtils, serverUtils) {
+/**
+ * @typedef CacheStat
+ * @property {string} cachegroup
+ * @property {number} connections
+ * @property {boolean} healthy
+ * @property {string} hostname
+ * @property {string | null} ip
+ * @property {number} kbps
+ * @property {string} profile
+ * @property {string} status
+ */
 
-	var cacheStatsInterval,
-		autoRefresh = false,
-		refreshRateInMS = 10000;
 
-	var createInterval = function() {
-		killInterval();
-		cacheStatsInterval = $interval(function() { $scope.refresh() }, refreshRateInMS );
-	};
+class CacheStatsHealthyCellRenderer {

Review comment:
       Because `CacheStatsSSHCellRenderer` needs access to the injected `userModel` service, but `CacheStatsHealthyCellRenderer` is pure functional




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org