You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rhtyd <gi...@git.apache.org> on 2016/07/21 20:03:28 UTC
[GitHub] cloudstack pull request #1614: CLOUDSTACK-9437: Fix egress chain and cleanup...
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1614
CLOUDSTACK-9437: Fix egress chain and cleanup for allow all traffic
- Fixes use of rules.v4/rules instead of router_rules.v4 file, this makes sure
that FW_EGRESS_RULE chain gets created on router systemvms
- Adds an explicit removal of allow all 0.0.0.0/0 (all protocol) egress rule
when adding the default egress rule (CLOUDSTACK-9437)
/cc @swill @jburwell @PaulAngus
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack vr-fix-egress
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1614.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1614
----
commit 7cde8edb833037cb247136f7c41a2d5242aa7864
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-07-21T19:54:32Z
CLOUDSTACK-9437: Fix egress chain and cleanup for allow all traffic
- Fixes use of rules.v4/rules instead of router_rules.v4 file, this makes sure
that FW_EGRESS_RULE chain gets created on router systemvms
- Adds an explicit removal of allow all 0.0.0.0/0 (all protocol) egress rule
when adding the default egress rule (CLOUDSTACK-9437)
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1614: [blocker] CLOUDSTACK-9437: Fix outbound traffic afte...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1614
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 3h 58m 32s
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__Jul_25_2016_17_55_07_M6G9VM:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/DeployDataCenter__Jul_25_2016_17_55_07_M6G9VM/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/DeployDataCenter__Jul_25_2016_17_55_07_M6G9VM/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/DeployDataCenter__Jul_25_2016_17_55_07_M6G9VM/runinfo.txt)
**`/tmp/MarvinLogs/test_network_EMU8Z2:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/test_network_EMU8Z2/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/test_network_EMU8Z2/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/test_network_EMU8Z2/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_SXGU89:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/test_vpc_routers_SXGU89/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/test_vpc_routers_SXGU89/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/test_vpc_routers_SXGU89/runinfo.txt)
Uploads will be available until `2016-09-24 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1614: [blocker] CLOUDSTACK-9437: Fix outbound traffic afte...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1614
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 2
Errors: 0
Duration: 4h 58m 47s
```
**Summary of the problem(s):**
```
FAIL: Create a redundant VPC with two networks with two VMs in each network and check default routes
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 559, in test_02_redundant_VPC_default_routes
self.do_default_routes_test()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 707, in do_default_routes_test
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_52ONA2/results.txt
```
```
FAIL: Create a VPC with two networks with one VM in each network and test default routes
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_router_nics.py", line 414, in test_02_VPC_default_routes
self.do_default_routes_test()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_router_nics.py", line 476, in do_default_routes_test
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_52ONA2/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__Jul_22_2016_16_53_45_QKIGS6:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/DeployDataCenter__Jul_22_2016_16_53_45_QKIGS6/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/DeployDataCenter__Jul_22_2016_16_53_45_QKIGS6/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/DeployDataCenter__Jul_22_2016_16_53_45_QKIGS6/runinfo.txt)
**`/tmp/MarvinLogs/test_network_52ONA2:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/test_network_52ONA2/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/test_network_52ONA2/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/test_network_52ONA2/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_EYX3UB:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/test_vpc_routers_EYX3UB/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/test_vpc_routers_EYX3UB/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1614/tmp/MarvinLogs/test_vpc_routers_EYX3UB/runinfo.txt)
Uploads will be available until `2016-09-24 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1614: [blocker] CLOUDSTACK-9437: Fix outbound traffic afte...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1614
This PR has merge conflicts with #1616, so I am manually merging them for now so I can test them together to see if it fixes the issues with this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1614: [blocker] CLOUDSTACK-9437: Fix outbound traff...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1614
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1614: [blocker] CLOUDSTACK-9437: Fix outbound traffic afte...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1614
Alright Will, closing now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1614: [blocker] CLOUDSTACK-9437: Fix outbound traffic afte...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1614
@pdube fixed a bunch of stuff in #1616 which seems to be working. I will test this PR with his PR to see if his fixes solve the issues connecting out with this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1614: [blocker] CLOUDSTACK-9437: Fix outbound traffic afte...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1614
The issues with this PR seem to be fixed with #1616, so I will merge both. This one has merge conflicts with #1616, but I am able to resolve the manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1614: [blocker] CLOUDSTACK-9437: Fix outbound traffic afte...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1614
I manually merged this into `master` (`d302269fe53ca0d3ef4c7d4c51b28ce94d8a4847`) because there were merge conflicts and I could not do it through `git pr`, so you can close this PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---