You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/07/22 02:48:23 UTC
[GitHub] [openwhisk] style95 opened a new pull request, #5292: Dedicated namespace
style95 opened a new pull request, #5292:
URL: https://github.com/apache/openwhisk/pull/5292
## Description
Actions run on any invokers in OpenWhisk. But users may want to run their actions on a certain invoker(s) for some reason such as IP-based ACL.
This is to provide dedicated invokers for a namespace. Operators can configure a dedicated namespace for invokers and all activations from the namespace will be delivered to the dedicated invokers only.
```
invoker0 ansible_host=${INVOKER01} tags="['dedicated']" dedicatedNamespaces="['namespace1']"
invoker1 ansible_host=${INVOKER02} tags="['dedicated']" dedicatedNamespaces="['namespace2']"
```
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [x] Scheduler
- [x] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [x] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on pull request #5292: Dedicated namespace
Posted by GitBox <gi...@apache.org>.
style95 commented on PR #5292:
URL: https://github.com/apache/openwhisk/pull/5292#issuecomment-1192125302
This feature was already partially contributed.
https://github.com/apache/openwhisk/blob/master/core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/ContainerManager.scala#L529
This PR is to make it complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on pull request #5292: Dedicated Invokers
Posted by GitBox <gi...@apache.org>.
style95 commented on PR #5292:
URL: https://github.com/apache/openwhisk/pull/5292#issuecomment-1192156273
I confirmed it's working as expected.
I configured invokers like this.
```bash
whisk/invokers/0/0
{"busyMemory":0,"dedicatedNamespaces":["guest"],"freeMemory":10240,"inProgressMemory":0,"status":"up","tags":["dedicated"]}
whisk/invokers/1/1
{"busyMemory":0,"dedicatedNamespaces":["whisk.system"],"freeMemory":10240,"inProgressMemory":0,"status":"up","tags":["dedicated"]}
whisk/invokers/2/2
{"busyMemory":0,"dedicatedNamespaces":[],"freeMemory":10240,"inProgressMemory":0,"status":"up","tags":[]}
whisk/invokers/3/3
{"busyMemory":0,"dedicatedNamespaces":[],"freeMemory":10240,"inProgressMemory":0,"status":"up","tags":[]}
whisk/invokers/4/4
{"busyMemory":0,"dedicatedNamespaces":[],"freeMemory":10240,"inProgressMemory":0,"status":"up","tags":[]}
whisk/invokers/5/5
{"busyMemory":0,"dedicatedNamespaces":[],"freeMemory":10240,"inProgressMemory":0,"status":"up","tags":[]}
whisk/invokers/6/6
{"busyMemory":0,"dedicatedNamespaces":[],"freeMemory":10240,"inProgressMemory":0,"status":"up","tags":[]}
whisk/invokers/7/7
{"busyMemory":0,"dedicatedNamespaces":[],"freeMemory":10240,"inProgressMemory":0,"status":"up","tags":[]}
whisk/invokers/8/8
{"busyMemory":0,"dedicatedNamespaces":[],"freeMemory":10240,"inProgressMemory":0,"status":"up","tags":[]}
whisk/invokers/9/9
{"busyMemory":0,"dedicatedNamespaces":[],"freeMemory":10240,"inProgressMemory":0,"status":"up","tags":[]}
```
And created 10 actions in `guest` and `whisk.system` namespace.
**create.sh**
```bash
#!/bin/bash
for i in {1..10}
do
wsk action update params$i tests/dat/actions/params.js -i -a invoker-resources '["dedicated"]'
done
```
And invoked them respectively.
```bash
#!/bin/bash
for i in {1..10}
do
wsk action invoke params$i -r -i
done
```
I confirmed all 10 actions only run on dedicated invokers respectively.
**guest(invoker0)**
```bash
whisk/namespace/guest/guest/params1/1-6051ac947a45aac1627d5de78744b6b4/invoker0/container/10afecfc5997f5af8d01717776fcd61b1f612a6669f2c7caf09fa3bab7c73b5d
whisk/namespace/guest/guest/params10/1-6123264a86af64c59273d4574fb773a8/invoker0/container/f24cbb3efd9b35cb80d1e0387b0cdd303aa15620773d278c5648014838f464a2
whisk/namespace/guest/guest/params2/1-f2568bab66da5aff45198b56397d1f32/invoker0/container/cae4c20e986e2b2019f05cf814f6ac9237a6739b75f93e438a0474ceee826890
whisk/namespace/guest/guest/params3/1-f9f5c689e9cac2fe61264cdf452f3469/invoker0/container/1b28fa7938695c28bef57c8ba5bc18aecd37534a195e591608c34984e3da7051
whisk/namespace/guest/guest/params3/1-f9f5c689e9cac2fe61264cdf452f3469/invoker0/container/6ef46b360e230fc6d9f3a4983d33f0453aa91f4fce3e9efab98525c0adad45e8
whisk/namespace/guest/guest/params4/1-49de0656975aa70be55adf6ecb53e9e7/invoker0/container/e342cddb78bbce8e3b4e24a1d6ca635e428490af2f6258f2d5d45cbf1e6ceafc
whisk/namespace/guest/guest/params5/1-40da6ab764bdd001c41a4db58c32be3e/invoker0/container/5c030a90c145145b291753fad934362c333b4e3ad123c69a8ef109c111b22a06
whisk/namespace/guest/guest/params6/1-4833318bd255ca08dbe0077b7e4e3cdc/invoker0/container/d202a3f52cb58b6dd465d49aadf531bef45d528bcad92b468f2deafb05305f4f
whisk/namespace/guest/guest/params7/1-80cdba467ff2c9e1cc71400735da4a41/invoker0/container/9f4ffe1d26eef147f49b52aca7a57e1f4bf6eb8ce6e98b94f6574ac283f7906e
whisk/namespace/guest/guest/params8/1-a32c872006ed9bf74816d7da4ca50fcd/invoker0/container/107570e5f27f5d36ee95daa0e0ca454173bd35617da510e3f28d5429072e9dfc
whisk/namespace/guest/guest/params9/1-0dfe91b13a09edba88324e46f7db887b/invoker0/container/b15cdf83cec6a680df4c1069a62673b835ee7d69afee65b9bd7fbf90632d2471
```
**whisk.system(invoker1)**
```bash
whisk/namespace/whisk.system/whisk.system/params1/1-3c9802cb7b3e8edd4d693c9ced357017/invoker1/container/a3c1de2727b4d64d993e968572e6e64c6e2da42e33079654e65d53b905b48156
whisk/namespace/whisk.system/whisk.system/params10/1-83364b391c341bd9a1f2f0ab7c54d513/invoker1/container/17c5cc9e2cb00f2d21b5943a0443d7d4f4dd6ed071977dfe46a892328a8159f3
whisk/namespace/whisk.system/whisk.system/params2/1-e057dc813043dc9e6129caf0cfe56c1f/invoker1/container/1adaa49a1f7e57d7f8780dd520e86bda5b07bacb7a97aca6e92d1888fd7684a7
whisk/namespace/whisk.system/whisk.system/params3/1-97842714bc91c90c857b9a101a4653b2/invoker1/container/577bf150ca48a3f1f6e31ed2dd2865d7c781cc0aa8389d93262c109430dc54f7
whisk/namespace/whisk.system/whisk.system/params4/1-b2b6491ba4777317faa82e09c173df1c/invoker1/container/5be71130c1b30b2320693ffabfec22931fec247bbc38dfe4ff9537fabc1095bc
whisk/namespace/whisk.system/whisk.system/params4/1-b2b6491ba4777317faa82e09c173df1c/invoker1/container/8132c0d4c5aea7f2085b022b91e437c8bae9884dbedf7b86998622aa80fce4c3
whisk/namespace/whisk.system/whisk.system/params5/1-4c7102162a9c6cd366deed9a70bb2518/invoker1/container/39f85c9330a77fe1114bf0d30178c56e2e0e16eb80cc8c6e961ff8310597a0db
whisk/namespace/whisk.system/whisk.system/params5/1-4c7102162a9c6cd366deed9a70bb2518/invoker1/container/781064d31396f62d350cb19a845a69e48c9702b7eb60bf367f496778edf31e93
whisk/namespace/whisk.system/whisk.system/params6/1-9bd24d443546fba82d4550a987140b72/invoker1/container/10c6ba1fc407436b627d1bbd12591893b937601c8576acf51e0d8b788aa7537e
whisk/namespace/whisk.system/whisk.system/params6/1-9bd24d443546fba82d4550a987140b72/invoker1/container/5f8a718926fc2738ce4a4ee7b52f6540d5e659106e6bc1e76884a24d70db43a1
whisk/namespace/whisk.system/whisk.system/params7/1-ab315bc8abdf341a03c6575a5bbdb951/invoker1/container/95bed4d7083375985c7d7b04822354cd3fc2eeddaeedb165b2c1aa93145f5f39
whisk/namespace/whisk.system/whisk.system/params8/1-ced39b1ad93a1fe360e9a21d47667710/invoker1/container/55eaa9f2789e1eebf3ff293e0f717e83879d223c17d10fc93976525bd9b8dffa
whisk/namespace/whisk.system/whisk.system/params9/1-f6dd155337373ba37aef4b93b1cccbee/invoker1/container/009f2762b5b9c4ce92f403c5c2a6c96357f25613f5c363701ae102f98b1ddc31
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 merged pull request #5292: Dedicated Invokers
Posted by GitBox <gi...@apache.org>.
style95 merged PR #5292:
URL: https://github.com/apache/openwhisk/pull/5292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on pull request #5292: Dedicated Invokers
Posted by GitBox <gi...@apache.org>.
style95 commented on PR #5292:
URL: https://github.com/apache/openwhisk/pull/5292#issuecomment-1192234838
> The pr titile may changed from `Dedicated Invokers` to `Dedicated namespace` ?
It was `Dedicated namespace` but I changed to `Dedicated Invokers` as the invoker is dedicated to a certain namespace.
<img width="652" alt="image" src="https://user-images.githubusercontent.com/3447251/180378051-85a0ee77-6ae5-4d7e-b4ba-17ab28587c40.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] ningyougang commented on pull request #5292: Dedicated Invokers
Posted by GitBox <gi...@apache.org>.
ningyougang commented on PR #5292:
URL: https://github.com/apache/openwhisk/pull/5292#issuecomment-1192157586
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-commenter commented on pull request #5292: Dedicated Invokers
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #5292:
URL: https://github.com/apache/openwhisk/pull/5292#issuecomment-1192139090
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5292?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#5292](https://codecov.io/gh/apache/openwhisk/pull/5292?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (108ffff) into [master](https://codecov.io/gh/apache/openwhisk/commit/d55d8fe86332c9996ccbb421233f60da2c70192f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d55d8fe) will **decrease** coverage by `75.32%`.
> The diff coverage is `16.66%`.
```diff
@@ Coverage Diff @@
## master #5292 +/- ##
==========================================
- Coverage 79.91% 4.58% -75.33%
==========================================
Files 238 238
Lines 14172 14178 +6
Branches 624 624
==========================================
- Hits 11325 650 -10675
- Misses 2847 13528 +10681
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/5292?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...la/org/apache/openwhisk/core/invoker/Invoker.scala](https://codecov.io/gh/apache/openwhisk/pull/5292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9JbnZva2VyLnNjYWxh) | `0.00% <0.00%> (-73.34%)` | :arrow_down: |
| [.../scala/org/apache/openwhisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/5292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `68.57% <100.00%> (-27.41%)` | :arrow_down: |
| [.../main/scala/org/apache/openwhisk/core/WarmUp.scala](https://codecov.io/gh/apache/openwhisk/pull/5292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvV2FybVVwLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ain/scala/org/apache/openwhisk/spi/SpiLoader.scala](https://codecov.io/gh/apache/openwhisk/pull/5292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL3NwaS9TcGlMb2FkZXIuc2NhbGE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...n/scala/org/apache/openwhisk/utils/JsHelpers.scala](https://codecov.io/gh/apache/openwhisk/pull/5292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL3V0aWxzL0pzSGVscGVycy5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...scala/org/apache/openwhisk/common/Prometheus.scala](https://codecov.io/gh/apache/openwhisk/pull/5292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Qcm9tZXRoZXVzLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...scala/org/apache/openwhisk/core/FeatureFlags.scala](https://codecov.io/gh/apache/openwhisk/pull/5292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvRmVhdHVyZUZsYWdzLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ala/org/apache/openwhisk/common/ConfigMXBean.scala](https://codecov.io/gh/apache/openwhisk/pull/5292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db25maWdNWEJlYW4uc2NhbGE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...la/org/apache/openwhisk/http/BasicRasService.scala](https://codecov.io/gh/apache/openwhisk/pull/5292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2h0dHAvQmFzaWNSYXNTZXJ2aWNlLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...a/org/apache/openwhisk/common/ConfigMapValue.scala](https://codecov.io/gh/apache/openwhisk/pull/5292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db25maWdNYXBWYWx1ZS5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [203 more](https://codecov.io/gh/apache/openwhisk/pull/5292/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] ningyougang commented on pull request #5292: Dedicated Invokers
Posted by GitBox <gi...@apache.org>.
ningyougang commented on PR #5292:
URL: https://github.com/apache/openwhisk/pull/5292#issuecomment-1192157444
The pr titile may changed from `Dedicated Invokers` to `Dedicated namespace` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org