You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Joe Stein <cr...@gmail.com> on 2014/02/09 16:30:02 UTC
Review Request 17879: Patch for KAFKA-1245
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17879/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1245
https://issues.apache.org/jira/browse/KAFKA-1245
Repository: kafka
Description
-------
KAFKA-1245 the jar files and pom are not being signed so nexus is failing to publish them
Diffs
-----
build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2
gradle.properties ad7a2f0f62930515ed0b74250dcc63069fb988de
Diff: https://reviews.apache.org/r/17879/diff/
Testing
-------
Thanks,
Joe Stein
Re: Review Request 17879: Patch for KAFKA-1245
Posted by Joe Stein <cr...@gmail.com>.
> On Feb. 10, 2014, 10:19 p.m., Jun Rao wrote:
> > gradle.properties, lines 21-24
> > <https://reviews.apache.org/r/17879/diff/1/?file=481157#file481157line21>
> >
> > Do you really intend to remove those lines?
>
> Joe Stein wrote:
> Yes, that was intentional.
>
> Those values are better (more safely) kept globally in ~/.gradle/gradle.properties along with signing.keyId, signing.password, signing.secretKeyRingFile
>
> My intent was to document setting these in the release documentation wiki. They should not be checked into the repo but kept global IMHO.
>
> Jun Rao wrote:
> Ok, then could you update README and build.gradle (the part that references local maven testing) accordingly?
will do
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17879/#review34115
-----------------------------------------------------------
On Feb. 9, 2014, 3:30 p.m., Joe Stein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17879/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2014, 3:30 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1245
> https://issues.apache.org/jira/browse/KAFKA-1245
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1245 the jar files and pom are not being signed so nexus is failing to publish them
>
>
> Diffs
> -----
>
> build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2
> gradle.properties ad7a2f0f62930515ed0b74250dcc63069fb988de
>
> Diff: https://reviews.apache.org/r/17879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Stein
>
>
Re: Review Request 17879: Patch for KAFKA-1245
Posted by Jun Rao <ju...@gmail.com>.
> On Feb. 10, 2014, 10:19 p.m., Jun Rao wrote:
> > gradle.properties, lines 21-24
> > <https://reviews.apache.org/r/17879/diff/1/?file=481157#file481157line21>
> >
> > Do you really intend to remove those lines?
>
> Joe Stein wrote:
> Yes, that was intentional.
>
> Those values are better (more safely) kept globally in ~/.gradle/gradle.properties along with signing.keyId, signing.password, signing.secretKeyRingFile
>
> My intent was to document setting these in the release documentation wiki. They should not be checked into the repo but kept global IMHO.
Ok, then could you update README and build.gradle (the part that references local maven testing) accordingly?
- Jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17879/#review34115
-----------------------------------------------------------
On Feb. 9, 2014, 3:30 p.m., Joe Stein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17879/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2014, 3:30 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1245
> https://issues.apache.org/jira/browse/KAFKA-1245
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1245 the jar files and pom are not being signed so nexus is failing to publish them
>
>
> Diffs
> -----
>
> build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2
> gradle.properties ad7a2f0f62930515ed0b74250dcc63069fb988de
>
> Diff: https://reviews.apache.org/r/17879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Stein
>
>
Re: Review Request 17879: Patch for KAFKA-1245
Posted by Joe Stein <cr...@gmail.com>.
> On Feb. 10, 2014, 10:19 p.m., Jun Rao wrote:
> > gradle.properties, lines 21-24
> > <https://reviews.apache.org/r/17879/diff/1/?file=481157#file481157line21>
> >
> > Do you really intend to remove those lines?
Yes, that was intentional.
Those values are better (more safely) kept globally in ~/.gradle/gradle.properties along with signing.keyId, signing.password, signing.secretKeyRingFile
My intent was to document setting these in the release documentation wiki. They should not be checked into the repo but kept global IMHO.
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17879/#review34115
-----------------------------------------------------------
On Feb. 9, 2014, 3:30 p.m., Joe Stein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17879/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2014, 3:30 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1245
> https://issues.apache.org/jira/browse/KAFKA-1245
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1245 the jar files and pom are not being signed so nexus is failing to publish them
>
>
> Diffs
> -----
>
> build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2
> gradle.properties ad7a2f0f62930515ed0b74250dcc63069fb988de
>
> Diff: https://reviews.apache.org/r/17879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Stein
>
>
Re: Review Request 17879: Patch for KAFKA-1245
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17879/#review34115
-----------------------------------------------------------
gradle.properties
<https://reviews.apache.org/r/17879/#comment64084>
Do you really intend to remove those lines?
- Jun Rao
On Feb. 9, 2014, 3:30 p.m., Joe Stein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17879/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2014, 3:30 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1245
> https://issues.apache.org/jira/browse/KAFKA-1245
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1245 the jar files and pom are not being signed so nexus is failing to publish them
>
>
> Diffs
> -----
>
> build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2
> gradle.properties ad7a2f0f62930515ed0b74250dcc63069fb988de
>
> Diff: https://reviews.apache.org/r/17879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Stein
>
>
Re: Review Request 17879: Patch for KAFKA-1245
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17879/#review34528
-----------------------------------------------------------
Ship it!
Thanks. I followed your instruction and was able to generate the pom file locally.
- Jun Rao
On Feb. 13, 2014, 7:41 p.m., Joe Stein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17879/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 7:41 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1245
> https://issues.apache.org/jira/browse/KAFKA-1245
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1245 updates to the README for how to use uploadArchivesAll
>
>
> KAFKA-1245 updates to the README for how to use uploadArchivesAll
>
>
> KAFKA-1245 the jar files and pom are not being signed so nexus is failing to publish them
>
>
> Diffs
> -----
>
> README.md e3fea22fe103dc690eef4956d535a4f3987b778c
> build.gradle 19bbbae030480b89ac3344f4d9c2618921148e8e
> gradle.properties ad7a2f0f62930515ed0b74250dcc63069fb988de
>
> Diff: https://reviews.apache.org/r/17879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Stein
>
>
Re: Review Request 17879: Patch for KAFKA-1245
Posted by Joe Stein <cr...@gmail.com>.
> On Feb. 14, 2014, 6:17 p.m., Jun Rao wrote:
> > How do I test this locally? I set mavenUrl to a local file, but I am not sure how to set the signing stuff, especially signing.secretKeyRingFile for local testing.
Install GNU Pgp http://www.gnupg.org/
gpg --gen-key
gpg --list-secret-keys --fingerprint
the number after the / in the first line is your signing.keyId, the password is whatever you choose in --gen-key and signing.secretKeyRingFile should be in the ~/.gnupg/secring.gpg directory (you can't use ~/ I don't think you have to use full path)
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17879/#review34521
-----------------------------------------------------------
On Feb. 13, 2014, 7:41 p.m., Joe Stein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17879/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 7:41 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1245
> https://issues.apache.org/jira/browse/KAFKA-1245
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1245 updates to the README for how to use uploadArchivesAll
>
>
> KAFKA-1245 updates to the README for how to use uploadArchivesAll
>
>
> KAFKA-1245 the jar files and pom are not being signed so nexus is failing to publish them
>
>
> Diffs
> -----
>
> README.md e3fea22fe103dc690eef4956d535a4f3987b778c
> build.gradle 19bbbae030480b89ac3344f4d9c2618921148e8e
> gradle.properties ad7a2f0f62930515ed0b74250dcc63069fb988de
>
> Diff: https://reviews.apache.org/r/17879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Stein
>
>
Re: Review Request 17879: Patch for KAFKA-1245
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17879/#review34521
-----------------------------------------------------------
How do I test this locally? I set mavenUrl to a local file, but I am not sure how to set the signing stuff, especially signing.secretKeyRingFile for local testing.
- Jun Rao
On Feb. 13, 2014, 7:41 p.m., Joe Stein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17879/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 7:41 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1245
> https://issues.apache.org/jira/browse/KAFKA-1245
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1245 updates to the README for how to use uploadArchivesAll
>
>
> KAFKA-1245 updates to the README for how to use uploadArchivesAll
>
>
> KAFKA-1245 the jar files and pom are not being signed so nexus is failing to publish them
>
>
> Diffs
> -----
>
> README.md e3fea22fe103dc690eef4956d535a4f3987b778c
> build.gradle 19bbbae030480b89ac3344f4d9c2618921148e8e
> gradle.properties ad7a2f0f62930515ed0b74250dcc63069fb988de
>
> Diff: https://reviews.apache.org/r/17879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Stein
>
>
Re: Review Request 17879: Patch for KAFKA-1245
Posted by Joe Stein <cr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17879/
-----------------------------------------------------------
(Updated Feb. 13, 2014, 7:41 p.m.)
Review request for kafka.
Bugs: KAFKA-1245
https://issues.apache.org/jira/browse/KAFKA-1245
Repository: kafka
Description (updated)
-------
KAFKA-1245 updates to the README for how to use uploadArchivesAll
KAFKA-1245 updates to the README for how to use uploadArchivesAll
KAFKA-1245 the jar files and pom are not being signed so nexus is failing to publish them
Diffs (updated)
-----
README.md e3fea22fe103dc690eef4956d535a4f3987b778c
build.gradle 19bbbae030480b89ac3344f4d9c2618921148e8e
gradle.properties ad7a2f0f62930515ed0b74250dcc63069fb988de
Diff: https://reviews.apache.org/r/17879/diff/
Testing
-------
Thanks,
Joe Stein