You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/05 09:01:26 UTC

[GitHub] [pulsar] andrasbeni opened a new issue, #17472: [Bug] Additional servlets are extracted to wrong directory when narExtractionDirectory is not set

andrasbeni opened a new issue, #17472:
URL: https://github.com/apache/pulsar/issues/17472

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### Version
   
   Pulsar version: 2.11-SNAPSHOT git hash: 359cfa7bc05
   OS: Mac OS
   
   ### Minimal reproduce step
   
   - Create an `AdditionalServlet` implementation.
   - Configure broker to use it.
   - Leave `narExtractionDirectory` in the `broker.conf` the default (empty string)
   - Start the broker.
   
   
   ### What did you expect to see?
   
   The broker should have extracted the file to `/tmp/pulsar-nar` as stated in the description of `narExtractionDirectory`.
   
   ### What did you see instead?
   
   The broker tried to extract the `.nar` file to`/pulsar-nar`.
   
   ### Anything else?
   
   Other plugin loaders (protocol handler, entry filter) work correctly.
   The problem is a difference in how e.g. [ProtocolHandlers.load](https://github.com/andrasbeni/pulsar/blob/ae16f192050a718404d6b9df3378b7df50a8b360/pulsar-broker/src/main/java/org/apache/pulsar/broker/protocol/ProtocolHandlers.java#L56) and [AdditionalServlets.load](https://github.com/andrasbeni/pulsar/blob/ae16f192050a718404d6b9df3378b7df50a8b360/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/web/plugin/servlet/AdditionalServlets.java#L72) read the property. 
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui closed issue #17472: [Bug] Additional servlets are extracted to wrong directory when narExtractionDirectory is not set

Posted by GitBox <gi...@apache.org>.
codelipenghui closed issue #17472: [Bug] Additional servlets are extracted to wrong directory when narExtractionDirectory is not set
URL: https://github.com/apache/pulsar/issues/17472


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] andrasbeni commented on issue #17472: [Bug] Additional servlets are extracted to wrong directory when narExtractionDirectory is not set

Posted by GitBox <gi...@apache.org>.
andrasbeni commented on issue #17472:
URL: https://github.com/apache/pulsar/issues/17472#issuecomment-1236734604

   For a quick reproduction, see PR https://github.com/apache/pulsar/pull/17450 : 
   When removing `brokerEnvs.put(PREFIX + "narExtractionDirectory", "/tmp");` from `TestAdditionalServlets.setupCluster`, the tests fail because the broker is unable to start.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org