You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Kenneth Knowles (Jira)" <ji...@apache.org> on 2022/06/03 20:19:00 UTC

[jira] [Commented] (BEAM-4284) PipelineTranslationTest.testProtoAgainstRehydrated() over-validates translated proto structure

    [ https://issues.apache.org/jira/browse/BEAM-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17546940#comment-17546940 ] 

Kenneth Knowles commented on BEAM-4284:
---------------------------------------

This issue has been migrated to https://github.com/apache/beam/issues/18752

> PipelineTranslationTest.testProtoAgainstRehydrated() over-validates translated proto structure
> ----------------------------------------------------------------------------------------------
>
>                 Key: BEAM-4284
>                 URL: https://issues.apache.org/jira/browse/BEAM-4284
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Scott Wegner
>            Priority: P3
>
> PipelineTranslationTest.testProtoAgainstRehydrated() validates round-tripping of a Pipeline object to and form proto, verifying each of the rehydrated fields. From conversations with [~lcwik], the validation logic is over-specified. There is no requirement that equivalent objects are serialized using the same ID. So iterating to find the set of unique IDs and validating the count is incorrect.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)