[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #840: feature: allow set up header to client in proxy-rewrite, support CORS header

[GitBox <gi...@apache.org>]

lilien1010 commented on a change in pull request #840: feature: allow set up header to client in proxy-rewrite,support CORS header
URL: https://github.com/apache/incubator-apisix/pull/840#discussion_r345158580
 
 

 ##########
 File path: doc/plugins/proxy-rewrite-cn.md
 ##########
 @@ -30,6 +30,7 @@
 |host            |可选| 转发到上游的新 `host` 地址，例如：`iresty.com` |
 |enable_websocket|可选| 是否启用 `websocket`（布尔值），默认不启用|
 |headers         |可选| 转发到上游的新`headers`，可以设置多个。头信息如果存在将重写，不存在则添加。想要删除某个 header 的话，把对应的值设置为空字符串即可|
+|resp_headers    |可选| 指定要输出出给客户端的Header，可以设置多个。头信息如果存在将重写，不存在则添加。|
 
 Review comment:
   in my opinion, the plugin `proxy-rewrite` here is offering rewriter function in the proxy server, both rewrite data to upstream and from upstream , it used to be modify header to upstream, now I add a rewirite header function to modify header to client, it still kind of `rewrite function`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services