You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/10/25 18:32:17 UTC
[kudu-CR] Fix MiniKdc dtor crash
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4839
to review the following change.
Change subject: Fix MiniKdc dtor crash
......................................................................
Fix MiniKdc dtor crash
The C++ MiniKdc had a bug that caused a CHECK failure when the dtor ran
while stopped.
Change-Id: Iccfa5cdbfadd82d021e9ccede020e1d19e7054fc
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java
M src/kudu/security/mini_kdc-test.cc
M src/kudu/security/mini_kdc.cc
3 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/4839/1
--
To view, visit http://gerrit.cloudera.org:8080/4839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccfa5cdbfadd82d021e9ccede020e1d19e7054fc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] Fix MiniKdc dtor crash
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Fix MiniKdc dtor crash
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4839/1/src/kudu/security/mini_kdc-test.cc
File src/kudu/security/mini_kdc-test.cc:
PS1, Line 52: TestStopDrop
Nit: TestStopDropAndRoll
--
To view, visit http://gerrit.cloudera.org:8080/4839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccfa5cdbfadd82d021e9ccede020e1d19e7054fc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Fix MiniKdc dtor crash
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Fix MiniKdc dtor crash
......................................................................
Fix MiniKdc dtor crash
The C++ MiniKdc had a bug that caused a CHECK failure when the dtor ran
while stopped.
Change-Id: Iccfa5cdbfadd82d021e9ccede020e1d19e7054fc
Reviewed-on: http://gerrit.cloudera.org:8080/4839
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Dan Burkert <da...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java
M src/kudu/security/mini_kdc-test.cc
M src/kudu/security/mini_kdc.cc
3 files changed, 15 insertions(+), 1 deletion(-)
Approvals:
Dan Burkert: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccfa5cdbfadd82d021e9ccede020e1d19e7054fc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Fix MiniKdc dtor crash
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Fix MiniKdc dtor crash
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccfa5cdbfadd82d021e9ccede020e1d19e7054fc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No