You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "ffernandez92 (via GitHub)" <gi...@apache.org> on 2024/04/22 12:33:39 UTC
[PR] [YAML] - Normalize YAML PubSub format [beam]
ffernandez92 opened a new pull request, #31068:
URL: https://github.com/apache/beam/pull/31068
addresses #31067
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YAML] - Normalize YAML PubSub format [beam]
Posted by "ffernandez92 (via GitHub)" <gi...@apache.org>.
ffernandez92 commented on PR #31068:
URL: https://github.com/apache/beam/pull/31068#issuecomment-2071841549
Run Python_Coverage PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YAML] - Normalize YAML PubSub format [beam]
Posted by "brucearctor (via GitHub)" <gi...@apache.org>.
brucearctor merged PR #31068:
URL: https://github.com/apache/beam/pull/31068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YAML] - Normalize YAML PubSub format [beam]
Posted by "ffernandez92 (via GitHub)" <gi...@apache.org>.
ffernandez92 commented on PR #31068:
URL: https://github.com/apache/beam/pull/31068#issuecomment-2071803260
Run Python PreCommit 3.9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YAML] - Normalize YAML PubSub format [beam]
Posted by "ffernandez92 (via GitHub)" <gi...@apache.org>.
ffernandez92 commented on PR #31068:
URL: https://github.com/apache/beam/pull/31068#issuecomment-2072334423
@brucearctor, I've updated the docs, website, and tests [I didn't see specific `examples` to fix] to ensure they are consistent with the new uppercase scenario. They currently function regardless of whether it's upper or lower case. However, I'd like to be prepared for when we deprecate the lowercase option so that we don't need to modify the tests.
As you've said, we can leave the PR open for a couple of days in case there is more feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YAML] - Normalize YAML PubSub format [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31068:
URL: https://github.com/apache/beam/pull/31068#issuecomment-2070044676
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @shunping for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YAML] - Normalize YAML PubSub format [beam]
Posted by "brucearctor (via GitHub)" <gi...@apache.org>.
brucearctor commented on PR #31068:
URL: https://github.com/apache/beam/pull/31068#issuecomment-2070572841
@ffernandez92 -- once you've confirmed docs/website/etc updated [ if necessary ], we can merge.
@robertwb -- should we also update syntax/style guide? That seems outside scope of this PR, but perhaps worth specifying to further specify desired conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org