You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2017/03/07 18:53:49 UTC
[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.
Alex Behm has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6296
Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint.
......................................................................
IMPALA-5028: Lock table in /catalog_objects endpoint.
There was a missing lock acquisition before
Table.toThrift() in the code used for implementing
the /catalog_objects endpoint in the WebUI.
Testing:
- Added a regression test in test_web_pages.py
Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
---
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M tests/webserver/test_web_pages.py
2 files changed, 29 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/6296/1
--
To view, visit http://gerrit.cloudera.org:8080/6296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint.
......................................................................
Patch Set 4:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/359/
--
To view, visit http://gerrit.cloudera.org:8080/6296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint.
......................................................................
IMPALA-5028: Lock table in /catalog_objects endpoint.
There was a missing lock acquisition before
Table.toThrift() in the code used for implementing
the /catalog_objects endpoint in the WebUI.
Testing:
- Added a regression test in test_web_pages.py
Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
Reviewed-on: http://gerrit.cloudera.org:8080/6296
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M tests/webserver/test_web_pages.py
2 files changed, 32 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has uploaded a new patch set (#3).
Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint.
......................................................................
IMPALA-5028: Lock table in /catalog_objects endpoint.
There was a missing lock acquisition before
Table.toThrift() in the code used for implementing
the /catalog_objects endpoint in the WebUI.
Testing:
- Added a regression test in test_web_pages.py
Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
---
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M tests/webserver/test_web_pages.py
2 files changed, 32 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/6296/3
--
To view, visit http://gerrit.cloudera.org:8080/6296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6296/1/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
PS1, Line 141: # IMPALA-5028: Test toThrift() of a partitioned table via the WebUI code path.
: self.get_and_check_status(self.CATALOG_OBJECT_URL +
: "?object_type=TABLE&object_name=functional.alltypes", "alltypes",
: without_ss=True)
> The error was thrown when the table was loaded. So I am wondering if we're
Good catch. I confirmed that only loaded tables are affected. I modified the test to run both against loaded and unloaded tables.
--
To view, visit http://gerrit.cloudera.org:8080/6296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint.
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6296/1/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
PS1, Line 141: # IMPALA-5028: Test toThrift() of a partitioned table via the WebUI code path.
: self.get_and_check_status(self.CATALOG_OBJECT_URL +
: "?object_type=TABLE&object_name=functional.alltypes", "alltypes",
: without_ss=True)
The error was thrown when the table was loaded. So I am wondering if we're getting the expected coverage with this tests.
--
To view, visit http://gerrit.cloudera.org:8080/6296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint.
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has uploaded a new patch set (#2).
Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint.
......................................................................
IMPALA-5028: Lock table in /catalog_objects endpoint.
There was a missing lock acquisition before
Table.toThrift() in the code used for implementing
the /catalog_objects endpoint in the WebUI.
Testing:
- Added a regression test in test_web_pages.py
Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
---
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M tests/webserver/test_web_pages.py
2 files changed, 32 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/6296/2
--
To view, visit http://gerrit.cloudera.org:8080/6296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3ad4ce286b8cc169f29b8ddfa215f8949b1c11ff
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>