You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by creker <gi...@git.apache.org> on 2016/04/04 18:23:20 UTC
[GitHub] thrift pull request: THRIFT-3467 Go Maps for Thrift Sets Should Ha...
GitHub user creker opened a pull request:
https://github.com/apache/thrift/pull/976
THRIFT-3467 Go Maps for Thrift Sets Should Have Values of Type struct{}
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/creker/thrift THRIFT-3467
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/976.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #976
----
commit 9c34db83d97952d432ac48e2de59119f81d8475a
Author: creker <sa...@yandex.ru>
Date: 2016-04-04T16:19:47Z
Go Maps for Thrift Sets Should Have Values of Type struct{}
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3467 Go Maps for Thrift Sets Should Ha...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/976
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3467 Go Maps for Thrift Sets Should Ha...
Posted by creker <gi...@git.apache.org>.
Github user creker commented on a diff in the pull request:
https://github.com/apache/thrift/pull/976#discussion_r58624605
--- Diff: test/go/src/bin/stress/main.go ---
@@ -201,7 +201,27 @@ func client(protocolFactory thrift.TProtocolFactory) {
atomic.AddInt64(&clicounter, 1)
}
case echoSet:
- s := map[int8]bool{-10: true, -9: true, -8: true, -7: true, -6: true, -5: true, -4: true, -3: true, -2: true, -1: true, 0: true, 1: true, 2: true, 3: true, 4: true, 5: true, 6: true, 7: true, 8: true}
+ s := map[int8]struct{}{
+ -10: struct{}{},
+ -9: struct{}{},
+ -8: struct{}{},
+ -7: struct{}{},
+ -6: struct{}{},
+ -5: struct{}{},
+ -4: struct{}{},
+ -3: struct{}{},
+ -2: struct{}{},
+ -1: struct{}{},
+ 0: struct{}{},
+ 1: struct{}{},
+ 2: struct{}{},
+ 3: struct{}{},
+ 4: struct{}{},
+ 5: struct{}{},
+ 6: struct{}{},
+ 7: struct{}{},
+ 8: struct{}{},
+ }
--- End diff --
And probably the most important one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3467 Go Maps for Thrift Sets Should Ha...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/976#discussion_r58624160
--- Diff: test/go/src/bin/stress/main.go ---
@@ -201,7 +201,27 @@ func client(protocolFactory thrift.TProtocolFactory) {
atomic.AddInt64(&clicounter, 1)
}
case echoSet:
- s := map[int8]bool{-10: true, -9: true, -8: true, -7: true, -6: true, -5: true, -4: true, -3: true, -2: true, -1: true, 0: true, 1: true, 2: true, 3: true, 4: true, 5: true, 6: true, 7: true, 8: true}
+ s := map[int8]struct{}{
+ -10: struct{}{},
+ -9: struct{}{},
+ -8: struct{}{},
+ -7: struct{}{},
+ -6: struct{}{},
+ -5: struct{}{},
+ -4: struct{}{},
+ -3: struct{}{},
+ -2: struct{}{},
+ -1: struct{}{},
+ 0: struct{}{},
+ 1: struct{}{},
+ 2: struct{}{},
+ 3: struct{}{},
+ 4: struct{}{},
+ 5: struct{}{},
+ 6: struct{}{},
+ 7: struct{}{},
+ 8: struct{}{},
+ }
--- End diff --
That's my favourite part of this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---