You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/03/08 09:32:31 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue #806: [Enhancement] a complement to code optimization for the eventmesh-examples module
Alonexc opened a new issue #806:
URL: https://github.com/apache/incubator-eventmesh/issues/806
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
In the eventmesh-examples module,http and grpc are not code optimized
### Describe the solution you'd like
<img width="679" alt="Screen Shot 2022-03-08 at 15 55 58" src="https://user-images.githubusercontent.com/91315508/157193493-3816eeac-011c-46e8-83e2-e2ba925fa63d.png"><img width="653" alt="Screen Shot 2022-03-08 at 16 13 46" src="https://user-images.githubusercontent.com/91315508/157194856-3d796ea5-e78c-4db2-83d0-441d9e094192.png">
<img width="432" alt="Screen Shot 2022-03-08 at 17 02 04" src="https://user-images.githubusercontent.com/91315508/157203490-56cd3540-e4c3-4847-94d2-64be80c027ab.png">
We suggest that such constants be placed in a constant class and the constant class be placed in the eventmesh-examples/src/main/java/org/apache/eventmesh/common package
<img width="408" alt="Screen Shot 2022-03-08 at 16 56 23" src="https://user-images.githubusercontent.com/91315508/157202417-2a1f8dfb-2773-41db-a0af-eda8cafa7e86.png">
delete invalid code.
located in：eventmesh-examples/src/main/java/org/apache/eventmesh/tcp/demo/sub/eventmeshmessage/AsyncSubscribe.java
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #806: [Enhancement] a complement to code optimization for the eventmesh-examples module
Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #806:
URL: https://github.com/apache/incubator-eventmesh/issues/806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] fengyongshe commented on issue #806: [Enhancement] a complement to code optimization for the eventmesh-examples module
Posted by GitBox <gi...@apache.org>.
fengyongshe commented on issue #806:
URL: https://github.com/apache/incubator-eventmesh/issues/806#issuecomment-1062453066
I'm willing to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on issue #806: [Enhancement] a complement to code optimization for the eventmesh-examples module
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on issue #806:
URL: https://github.com/apache/incubator-eventmesh/issues/806#issuecomment-1062489731
> I'm willing to do it.
welcome, if you have any problems please leave the message. @fengyongshe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org