You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Stas Bekman <st...@stason.org> on 2005/02/17 01:47:52 UTC
Re: [mp2] [PATCH] DESTDIR does not apply to mod_perl.so and includes
Cory Omand wrote:
> On Wed, 2005-02-16 at 13:18, Stas Bekman wrote:
>
>>But doesn't it need to deal with the trailing slash? Is it ok if someone
>>adds one and then it'll becomes foo//bar? I guess we also assume that the
>>right part always has the leading slash, since it's a real path to the
>>installed Apache dir, right? In the case of windows where it will become
>>fooc:\bar is probably irrelevant here.
>
>
> Stas,
>
> It shouldn't matter if someone specifies the trailing slash, as all
> that this path is used for is as an argument to $(MODPERL_CP). You
> are correct about the right portion -- it always will have the
> leading slash, because that path comes back from apxs. I hadn't
> considered the windows case, however. I've attached a new version
> of the patch which is 'volume aware', provides canonical paths, and
> would properly handle the case where apxs returns a path without a
> leading slash.
That's better, Cory, but why introducing new variables? you still kept the
old ones, but they aren't used anymore, are they? (e.g. AP_LIBEXECDIR)
Looks like a lot of extra noise.
May be keep the old makefile vars unchanged but merge the new prefix
transparently into those vars if the prefix exists? or at least drop the
not-used vars?
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] [PATCH] DESTDIR does not apply to mod_perl.so and includes
Posted by Stas Bekman <st...@stason.org>.
Cory Omand wrote:
[...]
>>That's better, Cory, but why introducing new variables? you still kept the
>>old ones, but they aren't used anymore, are they? (e.g. AP_LIBEXECDIR)
>>Looks like a lot of extra noise.
>>
>>May be keep the old makefile vars unchanged but merge the new prefix
>>transparently into those vars if the prefix exists? or at least drop the
>>not-used vars?
>
>
> My initial thought was that this should behave like DESTDIR for
> other packages -- it is only set on installation. Therefore, when
> you are using AP_LIBEXECDIR, you know it is pointing to where things
> will be when installed, but AP_LIBEXECDESTDIR is not referenced
> anywhere in the compilation portions of the makefile. As I have
> another look through the makefile, however, it appears that the
> only purpose of the MODPERL_AP_* variables is for installation, so
> maybe moving to use the existing variable names is fine...
>
> Another patch is attached --
Looks perfect to me, Cory
(it will need a few tiny style tweaks, but don't worry about that).
+1
once others vote on this it can go in.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] [PATCH] DESTDIR does not apply to mod_perl.so and includes
Posted by Stas Bekman <st...@stason.org>.
Cory Omand wrote:
With a few minor tweaks it's now committed. Thanks Cory.
You can see the detail of commit here:
http://svn.apache.org/viewcvs.cgi?rev=154318&view=rev
> +AP_DESTDIR 1 Destination for Apache specific mod_perl bits
I've changed this to 0. I don't think this option should be appendable.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org