You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/09 15:55:00 UTC

[jira] [Commented] (MINIFI-368) Cmake fails if a test file is opened in vim (dotfile exists)

    [ https://issues.apache.org/jira/browse/MINIFI-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120125#comment-16120125 ] 

ASF GitHub Bot commented on MINIFI-368:
---------------------------------------

GitHub user achristianson opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/125

    MINIFI-368 exclude hidden files when scanning for src files

    Updated regex matching when scanning for source files so that we don't pick up hidden files such as vim swap files.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFI-368

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #125
    
----
commit d3dd216c208b43a10aa086a5463ff906b430c490
Author: Andrew I. Christianson <an...@andyic.org>
Date:   2017-08-09T15:53:04Z

    MINIFI-368 exclude hidden files when scanning for src files

----


> Cmake fails if a test file is opened in vim (dotfile exists)
> ------------------------------------------------------------
>
>                 Key: MINIFI-368
>                 URL: https://issues.apache.org/jira/browse/MINIFI-368
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>          Components: C++
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>
> In vim's default configuration, dotfiles will be created adjacent to opened files. If a unit test is opened, this breaks the cmake build. This is due to cmake code which scans the filesystem for unit tests. It should be changed to filter out dotfiles.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)