You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2023/11/13 23:46:15 UTC
(superset) branch master updated: fix: naming denomalized to denormalized in helpers.py (#25973)
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 5def416f63 fix: naming denomalized to denormalized in helpers.py (#25973)
5def416f63 is described below
commit 5def416f632ae7d7f90ae615a8600e8110797aec
Author: Hugh A. Miles II <hu...@gmail.com>
AuthorDate: Mon Nov 13 18:46:09 2023 -0500
fix: naming denomalized to denormalized in helpers.py (#25973)
---
superset/models/helpers.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/superset/models/helpers.py b/superset/models/helpers.py
index 316a46c10c..fc947ff577 100644
--- a/superset/models/helpers.py
+++ b/superset/models/helpers.py
@@ -1343,11 +1343,11 @@ class ExploreMixin: # pylint: disable=too-many-public-methods
def values_for_column(self, column_name: str, limit: int = 10000) -> list[Any]:
# always denormalize column name before querying for values
db_dialect = self.database.get_dialect()
- denomalized_col_name = self.database.db_engine_spec.denormalize_name(
+ denormalized_col_name = self.database.db_engine_spec.denormalize_name(
db_dialect, column_name
)
cols = {col.column_name: col for col in self.columns}
- target_col = cols[denomalized_col_name]
+ target_col = cols[denormalized_col_name]
tp = self.get_template_processor()
tbl, cte = self.get_from_clause(tp)
@@ -1368,7 +1368,7 @@ class ExploreMixin: # pylint: disable=too-many-public-methods
sql = self.mutate_query_from_config(sql)
df = pd.read_sql_query(sql=sql, con=engine)
- return df[denomalized_col_name].to_list()
+ return df[denormalized_col_name].to_list()
def get_timestamp_expression(
self,