[jira] Created: (HADOOP-4364) IPC.Client.handleConnectionFailure should bail out if the retry count is >= the maximum, not ==

["Steve Loughran (JIRA)" <ji...@apache.org>]

IPC.Client.handleConnectionFailure should bail out if the retry count is >= the maximum, not ==
-----------------------------------------------------------------------------------------------

                 Key: HADOOP-4364
                 URL: https://issues.apache.org/jira/browse/HADOOP-4364
             Project: Hadoop Core
          Issue Type: Bug
          Components: ipc
    Affects Versions: 0.20.0
            Reporter: Steve Loughran
            Priority: Minor


Looking at the code in IPC.Client.handleConnectionFailure(), its clear that the connection setup exits if the client retrys equals the maximum specified

      if (curRetries == maxRetries) {
        throw ioe;
      }

But there's nothing to stop anyone setting ipc.client.connect.max.retries=0 in the configuration, and if that happens, the code will spin until the (integer) retry count wraps around. The test should be curRetries >= maxRetries

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.