[GitHub] [nifi] turcsanyip commented on a change in pull request #4463: NIFI-7714: QueryCassandra loses precision when converting timestamps to JSON

[GitBox <gi...@apache.org>]

turcsanyip commented on a change in pull request #4463:
URL: https://github.com/apache/nifi/pull/4463#discussion_r477208816



##########
File path: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java
##########
@@ -379,7 +406,7 @@ public static long convertToAvroStream(final ResultSet rs, final OutputStream ou
      * @throws TimeoutException     If a result set fetch has taken longer than the specified timeout
      * @throws ExecutionException   If any error occurs during the result set fetch
      */
-    public static long convertToJsonStream(final ResultSet rs, final OutputStream outStream,
+    public static long convertToJsonStream(final Optional<ProcessContext> context, final ResultSet rs, final OutputStream outStream,

Review comment:
       In my opinion we should not expose this method as `public`. It is unnecessary in general and I believe the signature will change when the SimpleDateFormat code is migrated to `java.time`.
   The javadoc should be moved to the original method (otherwise the new parameter should be added here).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org