You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/16 07:38:30 UTC
[GitHub] [doris] EmmyMiao87 opened a new pull request, #10911: fix tuple is null
EmmyMiao87 opened a new pull request, #10911:
URL: https://github.com/apache/doris/pull/10911
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] kpfly commented on a diff in pull request #10911: fix tuple is null
Posted by GitBox <gi...@apache.org>.
kpfly commented on code in PR #10911:
URL: https://github.com/apache/doris/pull/10911#discussion_r922647547
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/TupleIsNullPredicate.java:
##########
@@ -198,10 +198,16 @@ public static Expr unwrapExpr(Expr expr) {
public static void substitueListForTupleIsNull(List<Expr> exprs,
Map<List<TupleId>, TupleId> originToTargetTidMap) {
for (Expr expr : exprs) {
- if (!(expr instanceof TupleIsNullPredicate)) {
+ if (!(expr instanceof FunctionCallExpr)) {
continue;
}
- TupleIsNullPredicate tupleIsNullPredicate = (TupleIsNullPredicate) expr;
+ if (expr.getChildren().size() != 3) {
Review Comment:
3 is hard code,what's the meaning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #10911: fix tuple is null
Posted by GitBox <gi...@apache.org>.
morningman merged PR #10911:
URL: https://github.com/apache/doris/pull/10911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org