You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/09 04:41:58 UTC

[GitHub] [airflow] jedcunningham opened a new pull request, #24937: Only assert stuff for mypy when type checking

jedcunningham opened a new pull request, #24937:
URL: https://github.com/apache/airflow/pull/24937

   I recently discovered the section of CONTRIBUTING that mentions using asserts for type checking, when required, should be done in an `if TYPE_CHECKING` block:
   
   https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#dont-use-asserts-outside-tests
   
   This converts the obvious instances of it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #24937: Only assert stuff for mypy when type checking

Posted by GitBox <gi...@apache.org>.

potiuk merged PR #24937:
URL: https://github.com/apache/airflow/pull/24937


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org