You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/11/06 06:57:03 UTC

[GitHub] reminisce commented on a change in pull request #8558: slice operator supporting arbitrary values of step

reminisce commented on a change in pull request #8558: slice operator supporting arbitrary values of step
URL: https://github.com/apache/incubator-mxnet/pull/8558#discussion_r149004056
 
 

 ##########
 File path: src/operator/tensor/matrix_op.cc
 ##########
 @@ -246,11 +246,10 @@ will return a new array with shape ``(2,1,3,4)``.
 .add_argument("data", "NDArray-or-Symbol", "Source input")
 .add_arguments(ExpandDimParam::__FIELDS__());
 
-NNVM_REGISTER_OP(slice)
-.add_alias("_sparse_slice")
-.add_alias("crop")
+NNVM_REGISTER_OP(slice_v1)
 
 Review comment:
   Removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services