You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/27 14:03:28 UTC

[GitHub] [apisix-dashboard] nic-chen opened a new issue #2008: chore(CLI): show a friendly prompt, manager-api.pid exists but there's no corresponding process

nic-chen opened a new issue #2008:
URL: https://github.com/apache/apisix-dashboard/issues/2008


   ## Issue description
   
   When you shutdown the machine directly, the manager-api.pid won't be deleted.
   After rebooting and start manager-api, it reports “instance of the Manager API already running...” but actually it's not.
   
   we can show a friendly prompt: manager-api.pid exists but there's no corresponding process, and then start the new instance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] iamayushdas commented on issue #2008: chore: show a friendly prompt, manager-api.pid exists but there's no corresponding process

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on issue #2008:
URL: https://github.com/apache/apisix-dashboard/issues/2008#issuecomment-907114507


   @liuxiran this was the problem i was facing last day , i think this should be added to 2.7.2 milestone


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] bisakhmondal commented on issue #2008: chore: show a friendly prompt, manager-api.pid exists but there's no corresponding process

Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on issue #2008:
URL: https://github.com/apache/apisix-dashboard/issues/2008#issuecomment-907123776


   Hi @iamayushdas, Thanks for pointing it out. I have published the patch on [PR:2054](https://github.com/apache/apisix-dashboard/pull/2054).
   Sorry guys, it took long. Actually, I got caught up in some works.
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] bisakhmondal commented on issue #2008: chore: show a friendly prompt, manager-api.pid exists but there's no corresponding process

Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on issue #2008:
URL: https://github.com/apache/apisix-dashboard/issues/2008#issuecomment-894655656


   Hi @nic-chen, there is a `--force or -f`  flag to override this. Yeah, while adding that feature I haven't thought about shutdown behaviour. For sake of shutdown from the CLI and when the process is running itself as a daemon, we have this feature.
   
   However, I think instead of blindly returning an error/warning, we could just perform a lookup for that PID, if the process exists we will throw an error and if not, a new instance will be created.
   
   Let me know, how does this sound? I'll be happy to add the patch. Thanks :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on issue #2008: chore: show a friendly prompt, manager-api.pid exists but there's no corresponding process

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #2008:
URL: https://github.com/apache/apisix-dashboard/issues/2008#issuecomment-894871227


   @bisakhmondal  sure, welcome PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org