You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by lresende <gi...@git.apache.org> on 2016/07/15 21:29:57 UTC
[GitHub] zeppelin pull request #1194: [ZEPPELIN-1193] Update Node JS related dependen...
GitHub user lresende opened a pull request:
https://github.com/apache/zeppelin/pull/1194
[ZEPPELIN-1193] Update Node JS related dependencies to avoid RegExp DoS
### What is this PR for?
Update Node JS related dependencies to avoid intermittent build issues that suggest updates to avoid RegExp DoS
### What type of PR is it?
[Bug Fix]
### Todos
* [update minimatch] - Force minimatch to version 3.0.2 and up
### What is the Jira issue?
* [ZEPPELIN-1193](https://issues.apache.org/jira/browse/ZEPPELIN-1193)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lresende/incubator-zeppelin node
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1194.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1194
----
commit c199421f644c0ab0bc289da470f713653c0af70f
Author: Luciano Resende <lr...@apache.org>
Date: 2016-07-07T21:27:56Z
Update node.js and related plugins
commit b6709b6d84d577c837d29cfc23a588d425dff544
Author: Luciano Resende <lr...@apache.org>
Date: 2016-07-07T21:42:38Z
Put dependencies in alphabetical order
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1194: [ZEPPELIN-1193] Update Node JS related dependencies to...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1194
I am with limited internet access for the next week, so if anyone want to give it a try on continuing this I am fine, otherwise I can continue when I am back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1194: [ZEPPELIN-1193] Update Node JS related dependencies to...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1194
I do not think that node\npm version update are relevant - I was under impression that it's all about dependency version update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1194: [ZEPPELIN-1193] Update Node JS related dependen...
Posted by lresende <gi...@git.apache.org>.
Github user lresende closed the pull request at:
https://github.com/apache/zeppelin/pull/1194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1194: [ZEPPELIN-1193] Update Node JS related dependencies to...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1194
CI is failure [logs](https://s3.amazonaws.com/archive.travis-ci.org/jobs/145344524/log.txt) is not relevant and is tracked in [ZEPPELIN-862](https://issues.apache.org/jira/browse/ZEPPELIN-862)
```
Running org.apache.zeppelin.rest.ZeppelinSparkClusterTest
13:25:00,290 INFO org.apache.zeppelin.rest.AbstractTestRestApi:98 - Staring test Zeppelin up...
...
13:26:20,423 INFO org.apache.zeppelin.socket.NotebookServer:1248 - Job 20160717-132620_2044341447 is finished
Spark version detected 1.6.1
13:26:20,459 INFO org.apache.zeppelin.notebook.Paragraph:254 - run paragraph 20160717-132620_1544010668 using r org.apache.zeppelin.interpreter.LazyOpenInterpreter@4495b079
No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated
```
\cc @corneadoug @felizbear for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1194: [ZEPPELIN-1193] Update Node JS related dependencies to...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1194
@corneadoug did you have a chance to look into this one? Or would it require a too much of testing if done all together, what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1194: [ZEPPELIN-1193] Update Node JS related dependencies to...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1194
@lresende we still get the warning from before
(you can see it in the CI logs)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1194: [ZEPPELIN-1193] Update Node JS related dependencies to...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1194
I guess we better close this guy, or is it still WIP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1194: [ZEPPELIN-1193] Update Node JS related dependencies to...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1194
So what do you guys suggest we do @corneadoug @lresende ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1194: [ZEPPELIN-1193] Update Node JS related dependencies to...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1194
Didn't look into it,
If updating node/npm is supposed to remove this warning, then something is wrong with its install or its usage during the build.
I'm also not really familiar on how the build system install node/npm and if they run the install one or the global one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---