[GitHub] [nifi] exceptionfactory commented on pull request #5845: NIFI-9768: Fix indeterminate map ordering in testSchemaToAttribute

[GitBox <gi...@apache.org>]

exceptionfactory commented on PR #5845:
URL: https://github.com/apache/nifi/pull/5845#issuecomment-1108901911

   Sorry for the delay in responding to the latest updates @MarcyGO.
   
   Reviewing the most recent changes, I may not have communicated clearly in previous comments.
   
   I understand that the current change set adjusts the behavior of `TestAttributesToCSV`, but it is does not address the problem described in the original version of the PR.
   
   The this particular unit test class should remain unchanged, and it should continue to use the `assertAttributeEquals` method from `MockFlowFile`. If there is a problem with `assertAttributeEquals()`, then changes should be made to that method, and all impacted references should be updated. I realize that may involve changing other tests in addition to `TestAttributesToCSV`, but if that is necessary to correct the underlying behavior, that is a much better solution than changing individual tests to avoid using `assertAttributeEquals()`.
   
   Although the `NonDex` tool reports an issue, we have not observed indeterminate behavior in normal test execution. There may still be opportunity for improvement, but it may be worth closing this particular PR and addressing the more fundamental issue.
   
   Thanks again for your efforts!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org