You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Arun C Murthy (JIRA)" <ji...@apache.org> on 2012/08/30 14:36:07 UTC

[jira] [Created] (HADOOP-8748) Move dfsclient retry to a util class

Arun C Murthy created HADOOP-8748:
-------------------------------------

             Summary: Move dfsclient retry to a util class
                 Key: HADOOP-8748
                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
             Project: Hadoop Common
          Issue Type: Improvement
            Reporter: Arun C Murthy
            Assignee: Arun C Murthy
            Priority: Minor
             Fix For: 2.2.0-alpha


HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-8748:
----------------------------------

    Attachment: HADOOP-8748_branch1.patch

Trivial patch for branch-1.
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445946#comment-13445946 ] 

Hudson commented on HADOOP-8748:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1182 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1182/])
    HADOOP-8748. Refactor DFSClient retry utility methods to a new class in org.apache.hadoop.io.retry.  Contributed by Arun C Murthy (Revision 1378969)

     Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1378969
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java

                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-8748:
----------------------------------

    Status: Open  (was: Patch Available)

Trunk patch needs work to handle ServiceException.
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-8748:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed the branch-1 patch too.
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444961#comment-13444961 ] 

Hadoop QA commented on HADOOP-8748:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12543091/HADOOP-8748.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1389//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1389//console

This message is automatically generated.
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy closed HADOOP-8748.
---------------------------------

    
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.1.0, 2.0.2-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462878#comment-13462878 ] 

Arun C Murthy commented on HADOOP-8748:
---------------------------------------

Matt - if you don't mind, I'd like to merge this into branch-1.1 since it's a trivial change. Thoughts?
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.0.2-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-8748:
-------------------------------------------

    Component/s: io
    
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-8748:
----------------------------------

    Status: Patch Available  (was: Open)
    
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-8748:
-------------------------------------------

    Hadoop Flags: Reviewed

+1 patch looks good.
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-8748:
----------------------------------

    Attachment: HADOOP-8748_branch1.patch

Thanks for the review Nic, added the toString() method.
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-8748:
----------------------------------

       Fix Version/s: 1.2.0
    Target Version/s: 1.2.0, 2.2.0-alpha
              Status: Patch Available  (was: Open)
    
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444956#comment-13444956 ] 

Hadoop QA commented on HADOOP-8748:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12543082/HADOOP-8748.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ha.TestZKFailoverController

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1388//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1388//console

This message is automatically generated.
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444993#comment-13444993 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-8748:
------------------------------------------------

I have committed the trunk patch.  Thanks, Arun!

For the branch-1 patch, the toString() method is missing.
{code}
//DFSClient.java line 179
        @Override
        public String toString() {
          return "RetryPolicy[" + multipleLinearRandomRetry + ", "
              + RetryPolicies.TRY_ONCE_THEN_FAIL.getClass().getSimpleName()
              + "]";
        }
{code}
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-8748:
----------------------------------

    Fix Version/s:     (was: 1.2.0)
                   1.1.0

I just merged this to branch-1.1 after Matt's go ahead.
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.1.0, 2.0.2-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-8748:
----------------------------------

    Attachment: HADOOP-8748.patch

Trivial patch for trunk.
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445000#comment-13445000 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-8748:
------------------------------------------------

+1 for the branch-1 patch once the toString() method has been added.
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445891#comment-13445891 ] 

Hudson commented on HADOOP-8748:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1151 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1151/])
    HADOOP-8748. Refactor DFSClient retry utility methods to a new class in org.apache.hadoop.io.retry.  Contributed by Arun C Murthy (Revision 1378969)

     Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1378969
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java

                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-8748:
----------------------------------

    Attachment: HADOOP-8748.patch

Fixed trunk patch.
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8748) Move dfsclient retry to a util class

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444988#comment-13444988 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-8748:
------------------------------------------------

No new tests are needed since this is a simple refactoring.
                
> Move dfsclient retry to a util class
> ------------------------------------
>
>                 Key: HADOOP-8748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8748
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 1.2.0, 2.2.0-alpha
>
>         Attachments: HADOOP-8748_branch1.patch, HADOOP-8748.patch, HADOOP-8748.patch
>
>
> HDFS-3504 introduced mechanisms to retry RPCs. I want to move that to common to allow MAPREDUCE-4603 to share it too. Should be a trivial patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira