You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/11/20 01:56:35 UTC

[james-project] 07/49: [Refactoring] Cleanup SieveRepository exceptions

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit c7732f08fe7a6cb7be9b00b8bc98175c0a2e10ef
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Mon Nov 18 14:06:07 2019 +0700

    [Refactoring] Cleanup SieveRepository exceptions
---
 .../sieverepository/api/SieveQuotaRepository.java  |  3 ---
 .../james/sieverepository/api/SieveRepository.java |  6 ------
 .../api/exception/DuplicateException.java          | 21 ------------------
 .../api/exception/IsActiveException.java           | 22 -------------------
 .../api/exception/QuotaExceededException.java      | 15 -------------
 .../api/exception/QuotaNotFoundException.java      | 25 ----------------------
 .../api/exception/ScriptNotFoundException.java     |  8 -------
 .../api/exception/SieveRepositoryException.java    |  8 -------
 .../api/exception/StorageException.java            | 25 ----------------------
 9 files changed, 133 deletions(-)

diff --git a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/SieveQuotaRepository.java b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/SieveQuotaRepository.java
index a2f316b..72e8cd9 100644
--- a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/SieveQuotaRepository.java
+++ b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/SieveQuotaRepository.java
@@ -25,9 +25,6 @@ import org.apache.james.core.quota.QuotaSizeLimit;
 import org.apache.james.sieverepository.api.exception.QuotaNotFoundException;
 import org.apache.james.sieverepository.api.exception.StorageException;
 
-/**
- * SieveQuotaRepository
- */
 public interface SieveQuotaRepository {
 
     boolean hasDefaultQuota() throws StorageException;
diff --git a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/SieveRepository.java b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/SieveRepository.java
index e08af0e..31c67bd 100644
--- a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/SieveRepository.java
+++ b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/SieveRepository.java
@@ -45,12 +45,6 @@ public interface SieveRepository extends SieveQuotaRepository {
      * PutScript.
      *
      * <p><strong>Note:</strong> It is the responsibility of the caller to validate the script to be put.
-     *
-     * @param username
-     * @param name
-     * @param content
-     * @throws StorageException
-     * @throws QuotaExceededException
      */
     void putScript(Username username, ScriptName name, ScriptContent content) throws StorageException, QuotaExceededException;
     
diff --git a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/DuplicateException.java b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/DuplicateException.java
index 5c96bac..dc10f78 100644
--- a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/DuplicateException.java
+++ b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/DuplicateException.java
@@ -31,31 +31,10 @@ public class DuplicateException extends SieveRepositoryException {
 
     /**
      * Creates a new instance of DuplicateException.
-     *
-     * @param message
-     * @param cause
-     */
-    public DuplicateException(String message, Throwable cause) {
-        super(message, cause);
-    }
-
-    /**
-     * Creates a new instance of DuplicateException.
-     *
-     * @param message
      */
     public DuplicateException(String message) {
         super(message);
     }
 
-    /**
-     * Creates a new instance of DuplicateException.
-     *
-     * @param cause
-     */
-    public DuplicateException(Throwable cause) {
-        super(cause);
-    }
-
     private static final long serialVersionUID = 7384835765215418347L;
 }
\ No newline at end of file
diff --git a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/IsActiveException.java b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/IsActiveException.java
index 4efd03d..44cd09f 100644
--- a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/IsActiveException.java
+++ b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/IsActiveException.java
@@ -23,7 +23,6 @@ package org.apache.james.sieverepository.api.exception;
 public class IsActiveException extends SieveRepositoryException {
     /**
      * Creates a new instance of IsActiveException.
-     *
      */
     public IsActiveException() {
         super();
@@ -31,31 +30,10 @@ public class IsActiveException extends SieveRepositoryException {
 
     /**
      * Creates a new instance of IsActiveException.
-     *
-     * @param message
-     * @param cause
-     */
-    public IsActiveException(String message, Throwable cause) {
-        super(message, cause);
-    }
-
-    /**
-     * Creates a new instance of IsActiveException.
-     *
-     * @param message
      */
     public IsActiveException(String message) {
         super(message);
     }
 
-    /**
-     * Creates a new instance of IsActiveException.
-     *
-     * @param cause
-     */
-    public IsActiveException(Throwable cause) {
-        super(cause);
-    }
-
     private static final long serialVersionUID = 7472385325048232256L;
 }
\ No newline at end of file
diff --git a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/QuotaExceededException.java b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/QuotaExceededException.java
index 02508d7..f3bbcec 100644
--- a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/QuotaExceededException.java
+++ b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/QuotaExceededException.java
@@ -23,7 +23,6 @@ package org.apache.james.sieverepository.api.exception;
 public class QuotaExceededException extends SieveRepositoryException {
     /**
      * Creates a new instance of QuotaExceededException.
-     *
      */
     public QuotaExceededException() {
         super();
@@ -31,9 +30,6 @@ public class QuotaExceededException extends SieveRepositoryException {
 
     /**
      * Creates a new instance of QuotaExceededException.
-     *
-     * @param message
-     * @param cause
      */
     public QuotaExceededException(String message, Throwable cause) {
         super(message, cause);
@@ -41,21 +37,10 @@ public class QuotaExceededException extends SieveRepositoryException {
 
     /**
      * Creates a new instance of QuotaExceededException.
-     *
-     * @param message
      */
     public QuotaExceededException(String message) {
         super(message);
     }
 
-    /**
-     * Creates a new instance of QuotaExceededException.
-     *
-     * @param cause
-     */
-    public QuotaExceededException(Throwable cause) {
-        super(cause);
-    }
-
     private static final long serialVersionUID = -3966867419152420878L;
 }
\ No newline at end of file
diff --git a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/QuotaNotFoundException.java b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/QuotaNotFoundException.java
index 6defb85..d36906d 100644
--- a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/QuotaNotFoundException.java
+++ b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/QuotaNotFoundException.java
@@ -20,45 +20,20 @@
 
 package org.apache.james.sieverepository.api.exception;
 
-/**
- * <code>QuotaNotFoundException</code>
- */
 public class QuotaNotFoundException extends SieveRepositoryException {
     private static final long serialVersionUID = 6523546952593451503L;
 
     /**
      * Creates a new instance of QuotaNotFoundException.
-     *
      */
     public QuotaNotFoundException() {
     }
 
     /**
      * Creates a new instance of QuotaNotFoundException.
-     *
-     * @param message
-     * @param cause
-     */
-    public QuotaNotFoundException(String message, Throwable cause) {
-        super(message, cause);
-    }
-
-    /**
-     * Creates a new instance of QuotaNotFoundException.
-     *
-     * @param message
      */
     public QuotaNotFoundException(String message) {
         super(message);
     }
 
-    /**
-     * Creates a new instance of QuotaNotFoundException.
-     *
-     * @param cause
-     */
-    public QuotaNotFoundException(Throwable cause) {
-        super(cause);
-    }
-
 }
diff --git a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/ScriptNotFoundException.java b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/ScriptNotFoundException.java
index 5738186..2efac09 100644
--- a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/ScriptNotFoundException.java
+++ b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/ScriptNotFoundException.java
@@ -23,7 +23,6 @@ package org.apache.james.sieverepository.api.exception;
 public class ScriptNotFoundException extends SieveRepositoryException {
     /**
      * Creates a new instance of ScriptNotFoundException.
-     *
      */
     public ScriptNotFoundException() {
         super();
@@ -31,9 +30,6 @@ public class ScriptNotFoundException extends SieveRepositoryException {
 
     /**
      * Creates a new instance of ScriptNotFoundException.
-     *
-     * @param message
-     * @param cause
      */
     public ScriptNotFoundException(String message, Throwable cause) {
         super(message, cause);
@@ -41,8 +37,6 @@ public class ScriptNotFoundException extends SieveRepositoryException {
 
     /**
      * Creates a new instance of ScriptNotFoundException.
-     *
-     * @param message
      */
     public ScriptNotFoundException(String message) {
         super(message);
@@ -50,8 +44,6 @@ public class ScriptNotFoundException extends SieveRepositoryException {
 
     /**
      * Creates a new instance of ScriptNotFoundException.
-     *
-     * @param cause
      */
     public ScriptNotFoundException(Throwable cause) {
         super(cause);
diff --git a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/SieveRepositoryException.java b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/SieveRepositoryException.java
index c11227a..25162cc 100644
--- a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/SieveRepositoryException.java
+++ b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/SieveRepositoryException.java
@@ -23,7 +23,6 @@ package org.apache.james.sieverepository.api.exception;
 public class SieveRepositoryException extends Exception {
     /**
      * Creates a new instance of SieveRepositoryException.
-     *
      */
     public SieveRepositoryException() {
         super();
@@ -31,9 +30,6 @@ public class SieveRepositoryException extends Exception {
 
     /**
      * Creates a new instance of SieveRepositoryException.
-     *
-     * @param message
-     * @param cause
      */
     public SieveRepositoryException(String message, Throwable cause) {
         super(message, cause);
@@ -41,8 +37,6 @@ public class SieveRepositoryException extends Exception {
 
     /**
      * Creates a new instance of SieveRepositoryException.
-     *
-     * @param message
      */
     public SieveRepositoryException(String message) {
         super(message);
@@ -50,8 +44,6 @@ public class SieveRepositoryException extends Exception {
 
     /**
      * Creates a new instance of SieveRepositoryException.
-     *
-     * @param cause
      */
     public SieveRepositoryException(Throwable cause) {
         super(cause);
diff --git a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/StorageException.java b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/StorageException.java
index 6fbac3b..ace33f9 100644
--- a/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/StorageException.java
+++ b/server/data/data-api/src/main/java/org/apache/james/sieverepository/api/exception/StorageException.java
@@ -20,26 +20,12 @@
 
 package org.apache.james.sieverepository.api.exception;
 
-/**
- * <code>StorageException</code>
- */
 public class StorageException extends SieveRepositoryException {
 
     private static final long serialVersionUID = 7374111339714642386L;
 
     /**
      * Creates a new instance of StorageException.
-     *
-     */
-    public StorageException() {
-        super();
-    }
-
-    /**
-     * Creates a new instance of StorageException.
-     *
-     * @param message
-     * @param cause
      */
     public StorageException(String message, Throwable cause) {
         super(message, cause);
@@ -47,17 +33,6 @@ public class StorageException extends SieveRepositoryException {
 
     /**
      * Creates a new instance of StorageException.
-     *
-     * @param message
-     */
-    public StorageException(String message) {
-        super(message);
-    }
-
-    /**
-     * Creates a new instance of StorageException.
-     *
-     * @param cause
      */
     public StorageException(Throwable cause) {
         super(cause);


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org