You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/11/26 12:38:24 UTC

[GitHub] janpio edited a comment on issue #289: Properly handle custom URL schemes?

janpio edited a comment on issue #289: Properly handle custom URL schemes?
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/289#issuecomment-441624533
 
 
   Feel free to investigate this further @dd09012 - Cordova committers are volunteers working on this in their free time, and this doesn't seem to have been anyone's priority. 
   
   Suggestion 1: Create a new app with `cordova create`, implement the absolute minimum to be able to reproduce this feature/bug (e.g. "`loadstart` worsk with normal URLs, but not with custom URLs"), put it on GitHub and then post the URL to the repository here - this will make it much easier for someone to jump in. 
   
   After a contributor looked at this project and confirmed this as a bug, this issue will get the appropriate tag and it will be able to be fixed by someone looking for something to work on.
   
   
   --- 
   
   @lougreenwood 
   
   > http://git.lunargravity.be/project/Dag-secret-calculator/blob/3587c7a66a932c7de7183776880a55b4047eeb78/plugins/cordova-plugin-inappbrowser/src/android/InAppBrowser.java#L872
   
   No idea what codebase this links to, the current place of this code is at https://github.com/apache/cordova-plugin-inappbrowser/blob/0fd43ae64438a00bc0289aa2f7373bbff0c469fa/src/android/InAppBrowser.java#L1245-L1251
   
   > seemingly making intercepting the custom url scheme page loads with the 'loadstart' event not possible
   
   Is this speculation or have you tried this and it didn't work because of this code?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org