You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/06/20 06:06:18 UTC
[GitHub] [mynewt-nimble] bvdberg opened a new pull request, #1278: ble_conn: fix auth_pyld_timer memleak
bvdberg opened a new pull request, #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278
Every time a connection is made, the ble_npl_callout_init() is done.
This causes a timer creation in some NPL cases (eg. FreeRTOS).
The alloc behaviour of auth_pyld_timer is now in sync with ctrl_proc_rsp_timer
that lives in the same struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1278: ble_conn: fix auth_pyld_timer memleak
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1160012674
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] bvdberg commented on pull request #1278: ble_conn: fix auth_pyld_timer memleak
Posted by GitBox <gi...@apache.org>.
bvdberg commented on PR #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1165411741
I'm not sure about that. I see that at start, all connections you define (Max-Connections) get created and the timer also.
They are never freed, since the Max number of connections are compile-time defined. When a connection is reset (eg failed to connect) the state is reset, but the timer is not alloc'ed/freed, so that is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #1278: ble_conn: fix auth_pyld_timer memleak
Posted by GitBox <gi...@apache.org>.
sjanc commented on PR #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1165306690
I'm fine with having this hotfixed as is (although the leak will stil be present on each HCI reset call, right?)
in long term I think we need to expand npl api so that every init function has cleanup/deinit couterpart (or assume that some accounting will be handled by NPL layer eg freertos NPL could have internal list of timers and know if one was already created or not..)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc merged pull request #1278: ble_conn: fix auth_pyld_timer memleak
Posted by GitBox <gi...@apache.org>.
sjanc merged PR #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1278: ble_conn: fix auth_pyld_timer memleak
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1166916139
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] bvdberg commented on pull request #1278: ble_conn: fix auth_pyld_timer memleak
Posted by GitBox <gi...@apache.org>.
bvdberg commented on PR #1278:
URL: https://github.com/apache/mynewt-nimble/pull/1278#issuecomment-1166917530
rebased on update master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org