You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Neels Janosch Hofmeyr <ne...@elego.de> on 2009/06/03 02:31:18 UTC
ifndef SVN_LIBSVN_FS_FS_H
Two headers are having the same #define name.
That's bad, right?
[[[
~/svn/trunk
$ svngrep LIBSVN_FS_FS_H
./subversion/libsvn_fs_fs/fs.h:18:#ifndef SVN_LIBSVN_FS_FS_H
./subversion/libsvn_fs_fs/fs.h:19:#define SVN_LIBSVN_FS_FS_H
./subversion/libsvn_fs_fs/fs.h:381:#endif /* SVN_LIBSVN_FS_FS_H */
./subversion/libsvn_fs/fs-loader.h:20:#ifndef LIBSVN_FS_FS_H
./subversion/libsvn_fs/fs-loader.h:21:#define LIBSVN_FS_FS_H
$ cat `which svngrep`
grep -rn "$@" . | grep -v Binary | grep -v "\/\\.svn\/"
]]]
~Neels
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2358962
Re: ifndef SVN_LIBSVN_FS_FS_H
Posted by Neels Janosch Hofmeyr <ne...@elego.de>.
Blair Zajac wrote:
> On Jun 2, 2009, at 7:31 PM, Neels Janosch Hofmeyr wrote:
>
>> Two headers are having the same #define name.
>> That's bad, right?
>>
>> [[[
>> ~/svn/trunk
>> $ svngrep LIBSVN_FS_FS_H
>> ./subversion/libsvn_fs_fs/fs.h:18:#ifndef SVN_LIBSVN_FS_FS_H
>> ./subversion/libsvn_fs_fs/fs.h:19:#define SVN_LIBSVN_FS_FS_H
>> ./subversion/libsvn_fs_fs/fs.h:381:#endif /* SVN_LIBSVN_FS_FS_H */
>> ./subversion/libsvn_fs/fs-loader.h:20:#ifndef LIBSVN_FS_FS_H
>> ./subversion/libsvn_fs/fs-loader.h:21:#define LIBSVN_FS_FS_H
>
> Hmmm, those aren't the same SVN_LIBSVN_FS_FS_H vs LIBSVN_FS_FS_H.
... %]
How true. Don't know where my head was.
You must admit though, the difference is ... subtle? ... unexpected?
Anyway.
Sorry.
~Neels
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2359032
Re: ifndef SVN_LIBSVN_FS_FS_H
Posted by Blair Zajac <bl...@orcaware.com>.
On Jun 2, 2009, at 7:31 PM, Neels Janosch Hofmeyr wrote:
> Two headers are having the same #define name.
> That's bad, right?
>
> [[[
> ~/svn/trunk
> $ svngrep LIBSVN_FS_FS_H
> ./subversion/libsvn_fs_fs/fs.h:18:#ifndef SVN_LIBSVN_FS_FS_H
> ./subversion/libsvn_fs_fs/fs.h:19:#define SVN_LIBSVN_FS_FS_H
> ./subversion/libsvn_fs_fs/fs.h:381:#endif /* SVN_LIBSVN_FS_FS_H */
> ./subversion/libsvn_fs/fs-loader.h:20:#ifndef LIBSVN_FS_FS_H
> ./subversion/libsvn_fs/fs-loader.h:21:#define LIBSVN_FS_FS_H
Hmmm, those aren't the same SVN_LIBSVN_FS_FS_H vs LIBSVN_FS_FS_H.
Blair
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2358974