You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tr...@apache.org on 2017/05/23 11:40:23 UTC

flink git commit: [FLINK-6671] [tests] Make RocksDBStateBackendTest.testCancelRunningSnapshot stable

Repository: flink
Updated Branches:
  refs/heads/master 546e2ad73 -> f369f8640


[FLINK-6671] [tests] Make RocksDBStateBackendTest.testCancelRunningSnapshot stable

Let first the snapshotting thread completely finish before checking the test condition.
This prevents race conditions between the checkpointing thread and the verification.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/f369f864
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/f369f864
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/f369f864

Branch: refs/heads/master
Commit: f369f86400bcd52d1521eebbc7f1af1148a5a17e
Parents: 546e2ad
Author: Till Rohrmann <tr...@apache.org>
Authored: Tue May 23 13:38:18 2017 +0200
Committer: Till Rohrmann <tr...@apache.org>
Committed: Tue May 23 13:38:18 2017 +0200

----------------------------------------------------------------------
 .../flink/contrib/streaming/state/RocksDBStateBackendTest.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/f369f864/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
----------------------------------------------------------------------
diff --git a/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java b/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
index 89eb1d5..8d0db69 100644
--- a/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
+++ b/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
@@ -327,8 +327,8 @@ public class RocksDBStateBackendTest extends StateBackendTestBase<RocksDBStateBa
 		} catch (Exception ignored) {
 		}
 
-		verifyRocksObjectsReleased();
 		asyncSnapshotThread.join();
+		verifyRocksObjectsReleased();
 	}
 
 	@Test