You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/10/19 02:04:52 UTC

[GitHub] [orc] wgtmac commented on a diff in pull request #1282: ORC-1288: [C++] fix the bug that invalid memory freeing with zlib compression.

wgtmac commented on code in PR #1282:
URL: https://github.com/apache/orc/pull/1282#discussion_r998869772


##########
c++/test/TestWriter.cc:
##########
@@ -1996,5 +1996,49 @@ namespace orc {
     }
   }
 
+  void testSuppressPresentStream(orc::CompressionKind kind) {

Review Comment:
   nit: add some comment to explain why we have added the case since it does not have any ASSERT.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org