[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3134: Add try_unary_mut

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #3134:
URL: https://github.com/apache/arrow-rs/pull/3134#discussion_r1033841464


##########
arrow-array/src/builder/primitive_builder.rs:
##########
@@ -285,6 +285,26 @@ impl<T: ArrowPrimitiveType> PrimitiveBuilder<T> {
     pub fn values_slice_mut(&mut self) -> &mut [T::Native] {
         self.values_builder.as_slice_mut()
     }
+
+    /// Returns the current values buffer as a slice
+    #[allow(dead_code)]

Review Comment:
   I think this shouldn't be necessary, as they are public



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org