You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/03/18 13:30:46 UTC
Review Request 70230: Made volume gid manager not handle non-shared
PV.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70230/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9641
https://issues.apache.org/jira/browse/MESOS-9641
Repository: mesos
Description
-------
This patch reverts the following 3 patches which made volume gid manager
allocate & deallocate gid to non-shared PV.
https://reviews.apache.org/r/70137/
https://reviews.apache.org/r/70139/
https://reviews.apache.org/r/70140/
We want to keep the original behavior of non-shared PV, i.e., change its
owner to the task user, so that the task can fully control the volume,
i.e., the task can not only access the volume but also change its
metadata like changing the permissions of the volume (`chmod`).
Diffs
-----
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 725754f26855ea54ccf8cbcb288ee3b29e8ed4e7
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp dbf149ad9c8fb900bb3b56f6e90b3a8643097d25
src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
src/tests/containerizer/linux_filesystem_isolator_tests.cpp 60e9ae5970a0a45314d0b3569556bef36d350d2b
src/tests/persistent_volume_tests.cpp 7e929a5a3a92e16a5dec10206f37caebc20d66a8
Diff: https://reviews.apache.org/r/70230/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 70230: Made volume gid manager not handle
non-shared PV.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70230/#review213778
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70230]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 18, 2019, 1:30 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70230/
> -----------------------------------------------------------
>
> (Updated March 18, 2019, 1:30 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9641
> https://issues.apache.org/jira/browse/MESOS-9641
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch reverts the following 3 patches which made volume gid manager
> allocate & deallocate gid to non-shared PV.
> https://reviews.apache.org/r/70137/
> https://reviews.apache.org/r/70139/
> https://reviews.apache.org/r/70140/
>
> We want to keep the original behavior of non-shared PV, i.e., change its
> owner to the task user, so that the task can fully control the volume,
> i.e., the task can not only access the volume but also change its
> metadata like changing the permissions of the volume (`chmod`).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 725754f26855ea54ccf8cbcb288ee3b29e8ed4e7
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp dbf149ad9c8fb900bb3b56f6e90b3a8643097d25
> src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp 60e9ae5970a0a45314d0b3569556bef36d350d2b
> src/tests/persistent_volume_tests.cpp 7e929a5a3a92e16a5dec10206f37caebc20d66a8
>
>
> Diff: https://reviews.apache.org/r/70230/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70230: Made volume gid manager not handle
non-shared PV.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70230/#review213775
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70230']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2974/mesos-review-70230
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2974/mesos-review-70230/logs/mesos-tests.log):
```
I0318 14:44:44.174928 20968 executor.cpp:1027] Command exited with status 0 (pid: 20220)
I0318 14:44:45.177696 20196 process.cpp:927] Stopped the socket accept loop
W0318 14:44:45.179706 20196 process.cpp:1890] Failed to send 'mesos.internal.StatusUpdateMessage' to '192.10.1.6:53175', connect: IO failed with error code: The remote computer refused the network connection.
14:37:36.087920 16952 exec.cpp:518] Agent exited, but framework has checkpointing enabled. Waiting 15mins to reconnect with agent 91d24ac5-4ae1-4ca8-9ae7-f496c2fec447-S0
I0318 14:46:24.347802 13332 executor.cpp:1027] Command exited with status 0 (pid: 21164)
I0318 14:46:25.352614 10744 process.cpp:927] Stopped the socket accept loop
.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=396 to peer '192.10.1.6:54191': IO failed with error code: The specified network name is no longer available.
I0318 14:47:06.878350 12912 executor.cpp:1027] Command exited with status 0 (pid: 15008)
I0318 14:47:07.883435 18168 process.cpp:927] Stopped the socket accept loop
W0318 14:47:07.883435 18168 process.cpp:1890] Failed to send 'mesos.internal.StatusUpdateMessage' to '192.10.1.6:53175', connect: IO failed with error code: The remote computer refused the network connection.
4:37:36.087920 15832 exec.cpp:518] Agent exited, but framework has checkpointing enabled. Waiting 15mins to reconnect with agent a2d17922-91c2-4d97-b6cc-1c1414f1d709-S0
I0318 14:47:48.735365 15832 executor.cpp:1027] Command exited with status 0 (pid: 8188)
I0318 14:47:49.739440 18712 process.cpp:927] Stopped the socket accept loop
W0318 14:47:49.740430 18712 process.cpp:1890] Failed to send 'mesos.internal.StatusUpdateMessage' to '192.10.1.6:53175', connect: IO failed with error code: The remote computer refused the network connection.
I0318 14:52:36.143553 16700 executor.cpp:568] Recovery timeout of 15mins exceeded; Shutting down
I0318 14:52:36.143553 8760 executor.cpp:568] Recovery timeout of 15mins exceeded; Shutting down
I0318 14:52:36.144632 21048 default_executor.cpp:204] Received SHUTDOWN event
I0318 14:52:36.144632 4688 default_executor.cpp:204] Received SHUTDOWN event
I0318 14:52:36.144632 21048 default_executor.cpp:1025] Shutting down
I0318 14:52:36.144632 4688 default_executor.cpp:1025] Shutting down
I0318 14:52:36.144632 21048 default_executor.cpp:1081] Terminating after 1secs
I0318 14:52:36.144632 4688 default_executor.cpp:1081] Terminating after 1secs
I0318 14:52:37.148291 19188 process.cpp:927] Stopped the socket accept loop
I0318 14:52:37.148291 14748 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 18, 2019, 9:30 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70230/
> -----------------------------------------------------------
>
> (Updated March 18, 2019, 9:30 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9641
> https://issues.apache.org/jira/browse/MESOS-9641
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch reverts the following 3 patches which made volume gid manager
> allocate & deallocate gid to non-shared PV.
> https://reviews.apache.org/r/70137/
> https://reviews.apache.org/r/70139/
> https://reviews.apache.org/r/70140/
>
> We want to keep the original behavior of non-shared PV, i.e., change its
> owner to the task user, so that the task can fully control the volume,
> i.e., the task can not only access the volume but also change its
> metadata like changing the permissions of the volume (`chmod`).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 725754f26855ea54ccf8cbcb288ee3b29e8ed4e7
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp dbf149ad9c8fb900bb3b56f6e90b3a8643097d25
> src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp 60e9ae5970a0a45314d0b3569556bef36d350d2b
> src/tests/persistent_volume_tests.cpp 7e929a5a3a92e16a5dec10206f37caebc20d66a8
>
>
> Diff: https://reviews.apache.org/r/70230/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70230: Made volume gid manager not handle
non-shared PV.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70230/#review213785
-----------------------------------------------------------
Seems like this is not an optoin since then we have to read the mount table.
- Gilbert Song
On March 18, 2019, 6:30 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70230/
> -----------------------------------------------------------
>
> (Updated March 18, 2019, 6:30 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9641
> https://issues.apache.org/jira/browse/MESOS-9641
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch reverts the following 3 patches which made volume gid manager
> allocate & deallocate gid to non-shared PV.
> https://reviews.apache.org/r/70137/
> https://reviews.apache.org/r/70139/
> https://reviews.apache.org/r/70140/
>
> We want to keep the original behavior of non-shared PV, i.e., change its
> owner to the task user, so that the task can fully control the volume,
> i.e., the task can not only access the volume but also change its
> metadata like changing the permissions of the volume (`chmod`).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 725754f26855ea54ccf8cbcb288ee3b29e8ed4e7
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp dbf149ad9c8fb900bb3b56f6e90b3a8643097d25
> src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp 60e9ae5970a0a45314d0b3569556bef36d350d2b
> src/tests/persistent_volume_tests.cpp 7e929a5a3a92e16a5dec10206f37caebc20d66a8
>
>
> Diff: https://reviews.apache.org/r/70230/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>