[GitHub] yzhliu commented on a change in pull request #13574: Replaced rand_r with std:: random generation

[GitBox <gi...@apache.org>]

yzhliu commented on a change in pull request #13574: Replaced rand_r with std:: random generation
URL: https://github.com/apache/incubator-mxnet/pull/13574#discussion_r257130502
 
 

 ##########
 File path: src/operator/rnn_impl.h
 ##########
 @@ -176,13 +176,17 @@ void LstmForwardTraining(DType* ws,
       if (dropout > 0.0f) {
         #pragma omp parallel for num_threads(omp_threads)
         for (int j = 0; j < T * N * H * D; j++) {
-          int rand_data = rand_r(&seed_);
+          static thread_local std::random_device device;
 
 Review comment:
   suggest to refer to `RandGenerator<xpu>` as I mentioned below. It handles thread-safe problem without locking. The implement is somewhat tricky though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services