You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/29 08:47:28 UTC
[GitHub] [dubbo-go] Mulavar opened a new pull request #1548: fix error log when building route chain in the case we didn't configu…
Mulavar opened a new pull request #1548:
URL: https://github.com/apache/dubbo-go/pull/1548
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
fix error log when we didn't enable configuration center
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1548: fix error log when building route chain in the case we didn't configu…
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1548:
URL: https://github.com/apache/dubbo-go/pull/1548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1548: fix error log when building route chain in the case we didn't configu…
Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1548:
URL: https://github.com/apache/dubbo-go/pull/1548#discussion_r739144716
##########
File path: cluster/router/v3router/router_chain.go
##########
@@ -48,10 +48,11 @@ func NewUniformRouterChain() (router.PriorityRouter, error) {
// 1. add mesh route listener
r := &RouterChain{}
rootConfig := config.GetRootConfig()
- dynamicConfiguration, err := rootConfig.ConfigCenter.GetDynamicConfiguration()
- if err != nil {
- return nil, err
+ if rootConfig.ConfigCenter.DynamicConfiguration == nil {
+ logger.Infof("Config center does not start, please check if the configuration center has been properly configured in dubbogo.yml")
Review comment:
I think it should be info, because if the user do not config the config center, it is right that config center does not start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1548: fix error log when building route chain in the case we didn't configu…
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1548:
URL: https://github.com/apache/dubbo-go/pull/1548#issuecomment-955174168
This pr's ci may pass after pr https://github.com/apache/dubbo-go/pull/1549 merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1548: fix error log when building route chain in the case we didn't configu…
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1548:
URL: https://github.com/apache/dubbo-go/pull/1548#discussion_r739143367
##########
File path: cluster/router/v3router/router_chain.go
##########
@@ -48,10 +48,11 @@ func NewUniformRouterChain() (router.PriorityRouter, error) {
// 1. add mesh route listener
r := &RouterChain{}
rootConfig := config.GetRootConfig()
- dynamicConfiguration, err := rootConfig.ConfigCenter.GetDynamicConfiguration()
- if err != nil {
- return nil, err
+ if rootConfig.ConfigCenter.DynamicConfiguration == nil {
+ logger.Infof("Config center does not start, please check if the configuration center has been properly configured in dubbogo.yml")
Review comment:
the log level maybe should be warn?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org