[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11675: feat: use rison for list view filters stateful urls

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #11675:
URL: https://github.com/apache/incubator-superset/pull/11675#discussion_r523164585



##########
File path: superset-frontend/src/components/ListView/utils.ts
##########
@@ -78,6 +82,23 @@ export function convertFilters(fts: InternalFilter[]): FilterValue[] {
     .map(({ value, operator, id }) => ({ value, operator, id }));
 }
 
+// convertFilters but to handle new decoded rison format
+export function convertFiltersRison(filterObj: any): FilterValue[] {

Review comment:
       I noticed before that all unselected filters muddy the urls, can we filter out where `value === undefined`?
   
   Also did we consider going with a better/simpler data structure? maybe 
   ```js
   {
      user: ['==', 'mistercrunch'],
      dataset: ['==', 'some_dataset'],
   }
   ```
   `(dataset:!(==,some_dataset),user:!(==,mistercrunch))`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org