You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2023/07/03 07:48:43 UTC
[GitHub] [iceberg] snazy opened a new pull request, #7968: Remove `com.palantir.baseline-exact-dependencies` plugin
snazy opened a new pull request, #7968:
URL: https://github.com/apache/iceberg/pull/7968
The plugin description says: _Ensures projects explicitly declare all the dependencies they rely on, no more and no less_. However, I doubt that the plugin really works, because it there are transitive dependencies being used - and the negative side ("no more") doesn't seem to work at all.
BTW: The plugin causes issues in Nessie's integration test suite. The error indicates that the plugin does some things "wrong" wrt configuation and dependency management.
It forces "too eager" configuration, which produce errors that look like this:
```
* What went wrong:
Could not determine the dependencies of task ':nessie:nessie-iceberg:nessie-gc-iceberg:compileJava'.
> Could not resolve all dependencies for configuration ':nessie:nessie-iceberg:nessie-gc-iceberg:compileClasspath'.
> Cannot change dependencies of dependency configuration ':iceberg:iceberg-core:testImplementation' after it has been included in dependency resolution.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #7968: Remove `com.palantir.baseline-exact-dependencies` plugin
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #7968:
URL: https://github.com/apache/iceberg/pull/7968#issuecomment-1618258925
I like the idea of spotting dependencies that we don't use. But it seems like we don't run these checks?
```
➜ iceberg git:(51eaf6806) ./gradlew checkUnusedDependencies
Starting a Gradle Daemon (subsequent builds will be faster)
> Task :iceberg-flink:checkUnusedDependenciesMain FAILED
> Task :iceberg-spark:checkUnusedDependenciesMain FAILED
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':iceberg-flink:checkUnusedDependenciesMain'.
> Found 1 dependencies unused during compilation, please delete them from 'flink/build.gradle' or choose one of the suggested fixes:
org.slf4j:slf4j-api
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':iceberg-spark:checkUnusedDependenciesMain'.
> Found 1 dependencies unused during compilation, please delete them from 'spark/build.gradle' or choose one of the suggested fixes:
org.slf4j:slf4j-api
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================
* Get more help at https://help.gradle.org
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
See https://docs.gradle.org/8.1.1/userguide/command_line_interface.html#sec:command_line_warnings
BUILD FAILED in 8s
11 actionable tasks: 11 executed
➜ iceberg git:(51eaf6806) ./gradlew checkImplicitDependencies
> Task :iceberg-bundled-guava:shadowJar
Encountered duplicate path "META-INF/MANIFEST.MF" during copy operation configured with DuplicatesStrategy.WARN
Encountered duplicate path "org/apache/iceberg/GuavaClasses.class" during copy operation configured with DuplicatesStrategy.WARN
Encountered duplicate path "guava-31.1-jre.jar" during copy operation configured with DuplicatesStrategy.WARN
Encountered duplicate path "failureaccess-1.0.1.jar" during copy operation configured with DuplicatesStrategy.WARN
Encountered duplicate path "listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar" during copy operation configured with DuplicatesStrategy.WARN
Encountered duplicate path "LICENSE" during copy operation configured with DuplicatesStrategy.WARN
Encountered duplicate path "NOTICE" during copy operation configured with DuplicatesStrategy.WARN
> Task :iceberg-common:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
> Task :iceberg-api:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
> Task :iceberg-api:compileTestJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
> Task :iceberg-api:testJar
Encountered duplicate path "iceberg-build.properties" during copy operation configured with DuplicatesStrategy.WARN
> Task :iceberg-api:checkImplicitDependenciesTest FAILED
> Task :iceberg-core:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':iceberg-api:checkImplicitDependenciesTest'.
> Found 2 implicit dependencies - consider adding the following explicit dependencies to 'api/build.gradle', or avoid using classes from these jars:
dependencies {
testImplementation 'org.junit.jupiter:junit-jupiter-api'
testImplementation 'org.objenesis:objenesis'
}
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
* Get more help at https://help.gradle.org
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
See https://docs.gradle.org/8.1.1/userguide/command_line_interface.html#sec:command_line_warnings
BUILD FAILED in 15s
28 actionable tasks: 19 executed, 9 up-to-date
```
I'm open to removing it when it introduces issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Remove `com.palantir.baseline-exact-dependencies` plugin [iceberg]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #7968:
URL: https://github.com/apache/iceberg/pull/7968#issuecomment-1812685870
Yea - the plugin produces issues for us as mentioned in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Remove `com.palantir.baseline-exact-dependencies` plugin [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7968:
URL: https://github.com/apache/iceberg/pull/7968#issuecomment-2359659417
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Remove `com.palantir.baseline-exact-dependencies` plugin [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7968:
URL: https://github.com/apache/iceberg/pull/7968#issuecomment-2332935435
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Remove `com.palantir.baseline-exact-dependencies` plugin [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #7968: Remove `com.palantir.baseline-exact-dependencies` plugin
URL: https://github.com/apache/iceberg/pull/7968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org