You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zjncs (via GitHub)" <gi...@apache.org> on 2026/10/11 11:05:40 UTC
[PR] test(metrics): pin the resolved connection settings [rocketmq-dashboard]
zjncs opened a new pull request, #6270:
URL: https://github.com/apache/rocketmq-dashboard/pull/6270
### What
MetricsSourceSettings carries the resolved connection settings for a metrics backend. It had no test. This pins: the builder defaults (PROMETHEUS backend, 3s/10s budget, unauthenticated) and the query-path delegation - Mimir and VictoriaMetrics mount the Prometheus API under their own prefix.
### Verification
- New tests on unmodified code: **2/2 green**, checkstyle clean.
- Discriminating mutation: the connect-timeout default drifted to 5s (red).
- Restored: green. Test-only change; no product code touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(metrics): pin the resolved connection settings [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] commented on PR #6270:
URL: https://github.com/apache/rocketmq-dashboard/pull/6270#issuecomment-6672974501
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(metrics): pin the resolved connection settings [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] closed pull request #6270: test(metrics): pin the resolved connection settings
URL: https://github.com/apache/rocketmq-dashboard/pull/6270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org