You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Jonathan Gray <jg...@apache.org> on 2010/11/06 20:31:27 UTC
Review Request: HBASE-3048: Unify major/minor compactions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1185/
-----------------------------------------------------------
Review request for hbase, stack, Kannan Muthukkaruppan, and Ryan Rawson.
Summary
-------
This is a rebased patch from Amit. This was internally reviewed but we may want some minor modifications for 0.90 with the new InternalScanner, if possible. (suggestion from ryan on jira)
This addresses bug HBASE-3048.
http://issues.apache.org/jira/browse/HBASE-3048
Diffs
-----
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MinorCompactingStoreScanner.java 1031745
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java 1031745
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1031745
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java 1031745
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java 1031745
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinorCompactingStoreScanner.java 1031745
Diff: http://review.cloudera.org/r/1185/diff
Testing
-------
Lot's of good new additions by Amit to TestCompaction which passes.
Thanks,
Jonathan
Re: Review Request: HBASE-3048: Unify major/minor compactions
Posted by Jonathan Gray <jg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1185/#review1835
-----------------------------------------------------------
Looking at this now, it's at completely different level than the new InternalScan we have. That deals with scanner selection, this deals with an option in the QueryMatcher. There are already a bunch of options in SQM so we could consolidate at some point, but it's only a single level so doesn't seem so bad.
I'm +1 on it (it's not my patch) but want to get someone else to review.
- Jonathan
On 2010-11-06 15:50:30, Jonathan Gray wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1185/
> -----------------------------------------------------------
>
> (Updated 2010-11-06 15:50:30)
>
>
> Review request for hbase, stack, Kannan Muthukkaruppan, and Ryan Rawson.
>
>
> Summary
> -------
>
> This is a rebased patch from Amit. This was internally reviewed but we may want some minor modifications for 0.90 with the new InternalScanner, if possible. (suggestion from ryan on jira)
>
>
> This addresses bug HBASE-3048.
> http://issues.apache.org/jira/browse/HBASE-3048
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MinorCompactingStoreScanner.java 1032175
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java 1032175
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1032175
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java 1032175
> trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java 1032175
> trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinorCompactingStoreScanner.java 1032175
>
> Diff: http://review.cloudera.org/r/1185/diff
>
>
> Testing
> -------
>
> Lot's of good new additions by Amit to TestCompaction which passes.
>
>
> Thanks,
>
> Jonathan
>
>
Re: Review Request: HBASE-3048: Unify major/minor compactions
Posted by Ryan Rawson <ry...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1185/#review1837
-----------------------------------------------------------
Ship it!
ok lets go with this
- Ryan
On 2010-11-06 15:50:30, Jonathan Gray wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1185/
> -----------------------------------------------------------
>
> (Updated 2010-11-06 15:50:30)
>
>
> Review request for hbase, stack, Kannan Muthukkaruppan, and Ryan Rawson.
>
>
> Summary
> -------
>
> This is a rebased patch from Amit. This was internally reviewed but we may want some minor modifications for 0.90 with the new InternalScanner, if possible. (suggestion from ryan on jira)
>
>
> This addresses bug HBASE-3048.
> http://issues.apache.org/jira/browse/HBASE-3048
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MinorCompactingStoreScanner.java 1032175
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java 1032175
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1032175
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java 1032175
> trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java 1032175
> trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinorCompactingStoreScanner.java 1032175
>
> Diff: http://review.cloudera.org/r/1185/diff
>
>
> Testing
> -------
>
> Lot's of good new additions by Amit to TestCompaction which passes.
>
>
> Thanks,
>
> Jonathan
>
>
Re: Review Request: HBASE-3048: Unify major/minor compactions
Posted by Jonathan Gray <jg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1185/
-----------------------------------------------------------
(Updated 2010-11-06 15:50:30.615330)
Review request for hbase, stack, Kannan Muthukkaruppan, and Ryan Rawson.
Changes
-------
Minor cleanup of whitespace and stuff.
Summary
-------
This is a rebased patch from Amit. This was internally reviewed but we may want some minor modifications for 0.90 with the new InternalScanner, if possible. (suggestion from ryan on jira)
This addresses bug HBASE-3048.
http://issues.apache.org/jira/browse/HBASE-3048
Diffs (updated)
-----
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MinorCompactingStoreScanner.java 1032175
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java 1032175
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1032175
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java 1032175
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java 1032175
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinorCompactingStoreScanner.java 1032175
Diff: http://review.cloudera.org/r/1185/diff
Testing
-------
Lot's of good new additions by Amit to TestCompaction which passes.
Thanks,
Jonathan