You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "James William Dumay (JIRA)" <ji...@apache.org> on 2009/03/26 02:58:50 UTC
[jira] Created: (VFS-250) URLFileName should always honor trailing
slash for collections
URLFileName should always honor trailing slash for collections
--------------------------------------------------------------
Key: VFS-250
URL: https://issues.apache.org/jira/browse/VFS-250
Project: Commons VFS
Issue Type: Bug
Affects Versions: 2.0
Reporter: James William Dumay
Fix For: 2.0
URLFileName should always honor trailing slash for collections.
When using webdav VFS.getUriStyle() should always equal to true as operations on a collection resource without a trailing slash will result in a 301. This should be default for the URLFileName.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (VFS-250) URLFileName should always
honor trailing slash for collections
Posted by "Ludovic Maître (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800486#action_12800486 ]
Ludovic Maître edited comment on VFS-250 at 1/15/10 1:32 AM:
-------------------------------------------------------------
Hi!
Thanks for the patch, as a user of VFS it has been really boring to find why my apache was always sending redirect. Too bad that i had to dig in the code of URLFileName before i read this issue.
Is there any reason to not patch this issue ? In my case i use the webdav provider with a regular apache 2.2 with mod_dav, which send a redirect if the path didn't end by / and is a resource of type folder. I'm wondering how do other peoples and if we are only 2 peoples to use vfs to access apache mod_dav ?
Edit: I now use VFS.setURIStyle(true), and it works better.
was (Author: rastaman):
Hi!
Thanks for the patch, as a user of VFS it has been really boring to find why my apache was always sending redirect. Too bad that i had to dig in the code of URLFileName before i read this issue.
Is there any reason to not patch this issue ? In my case i use the webdav provider with a regular apache 2.2 with mod_dav, which send a redirect if the path didn't end by / and is a resource of type folder. I'm wondering how do other peoples and if we are only 2 peoples to use vfs to access apache mod_dav ?
> URLFileName should always honor trailing slash for collections
> --------------------------------------------------------------
>
> Key: VFS-250
> URL: https://issues.apache.org/jira/browse/VFS-250
> Project: Commons VFS
> Issue Type: Bug
> Affects Versions: 2.0
> Reporter: James William Dumay
> Fix For: 2.0
>
> Attachments: VFS-urlfilename-should-be-always-uri-style.patch
>
>
> URLFileName should always honor trailing slash for collections.
> When using webdav VFS.getUriStyle() should always equal to true as operations on a collection resource without a trailing slash will result in a 301. This should be default for the URLFileName.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VFS-250) URLFileName should always honor
trailing slash for collections
Posted by "Ludovic Maître (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800486#action_12800486 ]
Ludovic Maître commented on VFS-250:
------------------------------------
Hi!
Thanks for the patch, as a user of VFS it has been really boring to find why my apache was always sending redirect. Too bad that i had to dig in the code of URLFileName before i read this issue.
Is there any reason to not patch this issue ? In my case i use the webdav provider with a regular apache 2.2 with mod_dav, which send a redirect if the path didn't end by / and is a resource of type folder. I'm wondering how do other peoples and if we are only 2 peoples to use vfs to access apache mod_dav ?
> URLFileName should always honor trailing slash for collections
> --------------------------------------------------------------
>
> Key: VFS-250
> URL: https://issues.apache.org/jira/browse/VFS-250
> Project: Commons VFS
> Issue Type: Bug
> Affects Versions: 2.0
> Reporter: James William Dumay
> Fix For: 2.0
>
> Attachments: VFS-urlfilename-should-be-always-uri-style.patch
>
>
> URLFileName should always honor trailing slash for collections.
> When using webdav VFS.getUriStyle() should always equal to true as operations on a collection resource without a trailing slash will result in a 301. This should be default for the URLFileName.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (VFS-250) URLFileName should always
honor trailing slash for collections
Posted by "Ludovic Maître (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800486#action_12800486 ]
Ludovic Maître edited comment on VFS-250 at 1/15/10 1:35 AM:
-------------------------------------------------------------
Hi!
Thanks for the patch, as a user of VFS it has been really boring to find why my apache was always sending redirect.
I have discovered the VFS.setURIStyle() setting thanks to this issue, but it has not been easy to find, perhaps it should be more clearly stated in the documentation ?
Edit: Changed to show that i am now aware of the VFS.setURIStyle(true) settings and that since it works better.
was (Author: rastaman):
Hi!
Thanks for the patch, as a user of VFS it has been really boring to find why my apache was always sending redirect. Too bad that i had to dig in the code of URLFileName before i read this issue.
Is there any reason to not patch this issue ? In my case i use the webdav provider with a regular apache 2.2 with mod_dav, which send a redirect if the path didn't end by / and is a resource of type folder. I'm wondering how do other peoples and if we are only 2 peoples to use vfs to access apache mod_dav ?
Edit: I now use VFS.setURIStyle(true), and it works better.
> URLFileName should always honor trailing slash for collections
> --------------------------------------------------------------
>
> Key: VFS-250
> URL: https://issues.apache.org/jira/browse/VFS-250
> Project: Commons VFS
> Issue Type: Bug
> Affects Versions: 2.0
> Reporter: James William Dumay
> Fix For: 2.0
>
> Attachments: VFS-urlfilename-should-be-always-uri-style.patch
>
>
> URLFileName should always honor trailing slash for collections.
> When using webdav VFS.getUriStyle() should always equal to true as operations on a collection resource without a trailing slash will result in a 301. This should be default for the URLFileName.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (VFS-250) URLFileName should always honor trailing
slash for collections
Posted by "James William Dumay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James William Dumay updated VFS-250:
------------------------------------
Attachment: VFS-urlfilename-should-be-always-uri-style.patch
Patch overrides getPath() in URLFileName to ensure that the uri trailer is appended for FileTypes that have children even when VFS.isUriStyle() is false.
> URLFileName should always honor trailing slash for collections
> --------------------------------------------------------------
>
> Key: VFS-250
> URL: https://issues.apache.org/jira/browse/VFS-250
> Project: Commons VFS
> Issue Type: Bug
> Affects Versions: 2.0
> Reporter: James William Dumay
> Fix For: 2.0
>
> Attachments: VFS-urlfilename-should-be-always-uri-style.patch
>
>
> URLFileName should always honor trailing slash for collections.
> When using webdav VFS.getUriStyle() should always equal to true as operations on a collection resource without a trailing slash will result in a 301. This should be default for the URLFileName.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.