You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2010/02/12 03:14:27 UTC
[jira] Created: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
--------------------------------------------------------------------------------------
Key: HADOOP-6563
URL: https://issues.apache.org/jira/browse/HADOOP-6563
Project: Hadoop Common
Issue Type: Test
Components: fs, test
Reporter: Eli Collins
Assignee: Eli Collins
Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861602#action_12861602 ]
Hadoop QA commented on HADOOP-6563:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12441659/hadoop-6563-2.patch
against trunk revision 938590.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/484/console
This message is automatically generated.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Attachment: hadoop-6563-5.patch
The updated table is more clear, thanks. Modified tests like testRenameSymlinkToFileItLinksTo check the particular exception thrown (like the tests that cover renaming a file, directory, etc to itself). Added additional comments to the tests and fixed the typo. Patch attached.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch, hadoop-6563-5.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Attachment: hadoop-6563-3.patch
Attached patch merges with trunk.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Status: In Progress (was: Patch Available)
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Status: Open (was: Patch Available)
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862871#action_12862871 ]
Eli Collins commented on HADOOP-6563:
-------------------------------------
The TestFilterFileSystem failure is unrelated to this change, fails on trunk after HADOOP-6709. I'll track that down.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch, hadoop-6563-5.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Status: Patch Available (was: Open)
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Status: Patch Available (was: In Progress)
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Status: Open (was: Patch Available)
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862790#action_12862790 ]
Suresh Srinivas commented on HADOOP-6563:
-----------------------------------------
+1 for the patch.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch, hadoop-6563-5.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861627#action_12861627 ]
Hadoop QA commented on HADOOP-6563:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12443025/hadoop-6563-4.patch
against trunk revision 938590.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/59/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/59/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/59/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/59/console
This message is automatically generated.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-6563:
------------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
I committed the patch. Thank you Eli.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch, hadoop-6563-5.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-6563:
------------------------------------
Status: Patch Available (was: Open)
resubmitting the patch to trigger hudson tests.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch, hadoop-6563-5.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Attachment: hadoop-6563-2.patch
Fixes the javadoc warning.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861685#action_12861685 ]
Suresh Srinivas commented on HADOOP-6563:
-----------------------------------------
Modified the table you have a little bit. Hopefully it has more clarity:
||Source||Dest||Result||
|fileA|fileB|fileB is removed. fileA is renamed fileB|
| |dirB|Fails: both need to be file or directory|
| |linkB|linkB is removed (regardles of what it points to). fileA is renamed linkB|
|dirA|fileB|Fails: both need to be file or directory|
| |dirB|dirB is deleted(if empty). dirA is renamed to dirB|
| |linkB|Fails: if Source is a directory, then Dest must be a directory|
|linkA|fileB|fileB is deleted. linkA renamed to fileB|
| |dirB|if Dest is a directory then Source must be a directory|
| |linkB|linkB is removed (regardless of what it points to. linkA is renamed to linkB|
Comments:
# typo danling
# testRenameSymlinkToFileItLinksTo - when rename fails, should the test check for exception? Is this part of another jira?
# Why is creating dangling links allowed?
# Tests are hard to follow without additional descprition in the test methods what is being tested and what is expected. It took me a while to follow the tests.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Fix Version/s: 0.22.0
Affects Version/s: 0.22.0
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862007#action_12862007 ]
Suresh Srinivas commented on HADOOP-6563:
-----------------------------------------
Ignore my comment 3, since symlinks should allow creation of dangling links.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Attachment: hadoop-6563-4.patch
Right patch this time - sorry for the noise.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861620#action_12861620 ]
Hadoop QA commented on HADOOP-6563:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12443020/hadoop-6563-3.patch
against trunk revision 938590.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/57/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/57/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/57/console
This message is automatically generated.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Status: Patch Available (was: Open)
Kicking hudson.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Status: Patch Available (was: Open)
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-6563-1.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858054#action_12858054 ]
Eli Collins commented on HADOOP-6563:
-------------------------------------
Yes. See the initial comment for the caveat "conforms to the posix behavior (modulo the overwrite option which is not present in rename(2))".
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Status: Open (was: Patch Available)
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854777#action_12854777 ]
Hadoop QA commented on HADOOP-6563:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12441102/hadoop-6563-1.patch
against trunk revision 931226.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/447/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/447/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/447/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/447/console
This message is automatically generated.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-6563-1.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Status: Patch Available (was: Open)
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch, hadoop-6563-5.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Status: Open (was: Patch Available)
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch, hadoop-6563-5.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862846#action_12862846 ]
Hadoop QA commented on HADOOP-6563:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12443160/hadoop-6563-5.patch
against trunk revision 939510.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/491/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/491/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/491/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/491/console
This message is automatically generated.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch, hadoop-6563-5.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Status: Patch Available (was: Open)
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6563:
--------------------------------
Attachment: hadoop-6563-1.patch
Attached patch adds test coverage for intermediate symlinks in paths, and fixes a bug these tests uncovered.
It also adds a lot of rename unit tests so that the full set of behavior with symlinks, and it conforms to the posix behavior (modulo the overwrite option which is not present in {{rename(2)}}). Here's the current FileContext#rename behavior, renaming *source* to *dest* on HDFS, augmented with symlinks:
* If *source* does not exist then a FileNotFoundException is thrown.
* If *dest* does not exist then *source* is renamed *dest*. If *source* is a symlink then the symlink itself is renamed, not the link target.
* If *dest* exists and is a non-empty directory then an IOException is thrown.
* If *dest* exists and the OVERWRITE option is not given then an IOException is thrown.
* If *dest* exists and the OVERWRITE option is given then the behavior depends on the type of *source* and *dest*:
||Source|| Dest|| Result||
|fileA | fileB| Renames *fileA* to *fileB*|
| | dirB| Fails: both need to be file or directory|
| | linkB| *fileA* is renamed *linkB* (regardless of what *linkB* points to)|
|dirA | fileB| Fails: both need to be file or directory|
| | dirB| Renames *dirA* to *dirB* (*dirB* is empty)|
| | linkB| Fails: both need to be file or directory|
|linkA | fileB| Renames *linkA* to *fileB*|
| | dirB| Fails: *dirB* is a directory|
| | linkB| Renames *linkA* to *linkB* (regardless of what *linkB* points to)|
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-6563-1.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858033#action_12858033 ]
Suresh Srinivas commented on HADOOP-6563:
-----------------------------------------
Eli, does this functionality comply with rename specification of posix? It is available at http://www.opengroup.org/onlinepubs/000095399/functions/rename.html.
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-6563) Add more tests to
FileContextSymlinkBaseTest that cover intermediate symlinks in paths
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-6563:
------------------------------------
Status: Open (was: Patch Available)
> Add more tests to FileContextSymlinkBaseTest that cover intermediate symlinks in paths
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-6563
> URL: https://issues.apache.org/jira/browse/HADOOP-6563
> Project: Hadoop Common
> Issue Type: Test
> Components: fs, test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-6563-1.patch, hadoop-6563-2.patch, hadoop-6563-3.patch, hadoop-6563-4.patch, hadoop-6563-5.patch
>
>
> Intermediate symlinks in paths are covered by the tests that use /linkToDir/file, /linkToDir/subDir, etc eg testCreateVia* in FileContextSymlinkBaseTest. I'll add additional tests to cover other basic operations on paths like /dir/linkToSomeDir/file beyond create() and open().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.