You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/12 11:38:15 UTC
[GitHub] [apisix-website] Yiyiyimu opened a new pull request #303: chore: add alpha channel to showcase image for dark mode
Yiyiyimu opened a new pull request #303:
URL: https://github.com/apache/apisix-website/pull/303
Signed-off-by: yiyiyimu <wo...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu edited a comment on pull request #303: chore: add alpha channel to showcase image for dark mode
Posted by GitBox <gi...@apache.org>.
Yiyiyimu edited a comment on pull request #303:
URL: https://github.com/apache/apisix-website/pull/303#issuecomment-817744716
Since the images coming from CDN, so the preview sites could not show updated images. It seems the only thing I could do is to add some screenshots of open them locally in photoshop 🤦
Before:

After:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #303: chore: add alpha channel to showcase image for dark mode
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #303:
URL: https://github.com/apache/apisix-website/pull/303#issuecomment-817744716
It seems the preview sites not showing the new version of those showcase images. So I could only to add some screenshots of open them locally in photoshop 🤦
Before:

After:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #303: chore: add alpha channel to showcase image for dark mode
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #303:
URL: https://github.com/apache/apisix-website/pull/303#issuecomment-817738029
Deploy preview for *apisix* ready!
Built with commit e9c85cc5c4c3d8de2d9fdd437d08436bece88118
https://deploy-preview-303--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #303: chore: add alpha channel to showcase image for dark mode
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #303:
URL: https://github.com/apache/apisix-website/pull/303#issuecomment-819149657


Wow, I see so many images got updated, but some images seem broken or too dark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu edited a comment on pull request #303: chore: add alpha channel to showcase image for dark mode
Posted by GitBox <gi...@apache.org>.
Yiyiyimu edited a comment on pull request #303:
URL: https://github.com/apache/apisix-website/pull/303#issuecomment-817744716
Since the images coming from CDN, so the preview sites could not show updated images. It seems the only thing I could do is to add some screenshots of opening them locally in photoshop 🤦
Before:

After:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #303: chore: add alpha channel to showcase image for dark mode
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #303:
URL: https://github.com/apache/apisix-website/pull/303#issuecomment-817738029
Deploy preview for *apisix* processing.
Building with commit e9c85cc5c4c3d8de2d9fdd437d08436bece88118
https://app.netlify.com/sites/apisix/deploys/607435c74e369500071f9dd6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #303: chore: add alpha channel to showcase image for dark mode
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #303:
URL: https://github.com/apache/apisix-website/pull/303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #303: chore: add alpha channel to showcase image for dark mode
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #303:
URL: https://github.com/apache/apisix-website/pull/303#issuecomment-817738029
Deploy preview for *apisix* ready!
Built with commit 90f8a0762f61a7a7b2b98ab7d0562ad77fe62dbe
https://deploy-preview-303--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #303: chore: add alpha channel to showcase image for dark mode
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #303:
URL: https://github.com/apache/apisix-website/pull/303#issuecomment-817738029
Deploy preview for *apisix* processing.
Building with commit 90f8a0762f61a7a7b2b98ab7d0562ad77fe62dbe
https://app.netlify.com/sites/apisix/deploys/6074312154c41e0008aadd51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #303: chore: add alpha channel to showcase image for dark mode
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #303:
URL: https://github.com/apache/apisix-website/pull/303#issuecomment-819173058
> Wow, I see so many images got updated, but some images seem broken or too dark?
@juzhiyuan On my side, no images got updated 🤣 The reason is all images coming from CDN, and it would not got updated when only in PR.
That's the same reason those two images got broken. I changed them from svg to png, so we could not use the original source from CDN anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org