[GitHub] [iotdb] kr11 commented on pull request #2299: Fix dependency bug and add documents

[GitBox <gi...@apache.org>]

kr11 commented on pull request #2299:
URL: https://github.com/apache/iotdb/pull/2299#issuecomment-748836299


   > > As the Github image website `githubusercontent.com` is unstable, Shall we create an image directory for all used images and refer to them with relative links? just like what ![zeppelin docs](https://github.com/apache/zeppelin/tree/master/docs/assets/themes/zeppelin/img) does.
   > 
   > I think it may cause another problem. When we clone the code from the IoTDB repository, we may have to download these images to our local computers. These images may take a lot of disk space....
   
   I understand and quite agree that we should separate image resources from the code repository.
   The change has been done.
   
   Just a few extra ideas. `github.com ` and `githubusercontent.com ` have different web links and ips, thus users may be able to view the former but blocked by the latter. In the future, we could consider storing our images in another `github.com` repository, instead of `githubusercontent.com `, although it's really convenient. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org